Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upClean up Client and Server integration tests #1675
Open
Comments
|
I will take this issue and work on it! |
|
Would you have something in mind as well? @seanmonstar |
|
@seanmonstar is it still open? :) |
|
Yes, this is still open because the integration tests feel very messy, and there's a lot of repeated code. I'm sorry I haven't been able to provide much guidance on how to improve them, if I thought about it a lot, I'd probably fix them myself :) |
|
Well, if it's very messy so we could improve it a little each PR, for example let's remove (as many as possible) repeated code first. If you feel ok with this approach I could try it :) (hopefully it's easy as labelled :D). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Both the client and server tests (
tests/client.rsandtests/server.rs) started with small abstractions, but they weren't flexible enough, and so as more complicated cases were needed, the tests just got more and more complicated, with a lot of repetition. It'd be huge to find a way to refactor them.