Skip to content

/ cz-cli

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"improvement" offered as an option but not in enum #681

Open
ktwbc opened this issue Oct 12, 2019 · 5 comments
Open

"improvement" offered as an option but not in enum #681

ktwbc opened this issue Oct 12, 2019 · 5 comments

Comments

@ktwbc
Copy link

@ktwbc ktwbc commented Oct 12, 2019

When using git cz, one option for a type to select is "improvement", but this fails the enum check


husky > commit-msg hook failed (add --no-verify to bypass)
git exited with error code 1
kris@Kriss-MacBook-Pro cent-admin % git cz
cz-cli@4.0.3, cz-conventional-changelog@3.0.1

? Select the type of change that you're committing: 
  revert:      Reverts a previous commit 
  feat:        A new feature 
  fix:         A bug fix 
❯ improvement: An improvement to a current feature 
  docs:        Documentation only changes 



⧗   input: improvement(employers): added new subscriptions
✖   type must be one of [build, chore, ci, docs, feat, fix, perf, refactor, revert, style, test] [type-enum]

✖   found 1 problems, 0 warnings
ⓘ   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint
@OmgImAlexis
Copy link

@OmgImAlexis OmgImAlexis commented Oct 14, 2019

Found where the issue is coming from commitizen/conventional-commit-types@d849665
@OmgImAlexis
Copy link

@OmgImAlexis OmgImAlexis commented Oct 14, 2019

commitizen/conventional-commit-types#13
@OmgImAlexis
Copy link

@OmgImAlexis OmgImAlexis commented Oct 14, 2019 •
edited

I believe this is what needs updating.

https://github.com/conventional-changelog/commitlint/blob/master/%40commitlint/config-angular-type-enum/index.js

and this

https://github.com/conventional-changelog/commitlint/blob/master/%40commitlint/config-conventional/index.js#L16
@OmgImAlexis OmgImAlexis mentioned this issue Oct 17, 2019
Merged
@OmgImAlexis
Copy link

@OmgImAlexis OmgImAlexis commented Oct 21, 2019

@jimthedev since conventional-changelog/commitlint#832 has been merged can we get config-conventional's version bumped please.
@AndersDJohnson AndersDJohnson mentioned this issue Nov 3, 2019
Merged
@AndersDJohnson
Copy link
Member

@AndersDJohnson AndersDJohnson commented Nov 3, 2019

@OmgImAlexis @ktwbc @jimthedev It looks like they removed improvement as recommended. It was in their 1.0.0-beta.4 release, but removed in 1.0.0.

I'm proposing we consider removing it in commitizen/conventional-commit-types#16, so I would appreciate if you could share thoughts there.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Add improvement to allowed list.
3 participants
@AndersDJohnson @ktwbc @OmgImAlexis
You can’t perform that action at this time.