Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFork legacy-events folder into react-dom and react-native #19228
+2,422
−107
Conversation
| @@ -0,0 +1,66 @@ | |||
| /** | |||
This comment has been minimized.
This comment has been minimized.
codesandbox
bot
commented
Jul 1, 2020
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit bddd4c5:
|
sizebot
commented
Jul 1, 2020
|
I gave it a quick glance over, given the size of changes, and things look good. :) |
sizebot
commented
Jul 1, 2020
gaearon
merged commit e3f4eb7
into
facebook:master
31 checks passed
31 checks passed
ci/circleci: RELEASE_CHANNEL_stable_yarn_test_prod_www_variant
Your tests passed on CircleCI!
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
gaearon commentedJul 1, 2020
This removes top-level
legacy-events/*and instead copies all files into two folders:react-dom/src/legacy-events/*react-native-renderer/src/legacy-events/*I updated all the import references.
This gives us a clear separation and lets us remove most of that from the DOM folder when we flip the flag.