Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUse a bunch of BoringSSL accessors. #856
Conversation
| *signature = x509->signature; | ||
| static const ASN1_BIT_STRING* get_X509_signature(X509* x509) { | ||
| const ASN1_BIT_STRING* signature; | ||
| X509_get0_signature(&signature, nullptr, x509); |
This comment has been minimized.
This comment has been minimized.
davidben
Jun 20, 2020
Author
Contributor
(I don't know why X509_get0_signature and X509_CRL_get0_signature have different argument orders. OpenSSL...)
We're starting to chew through the blockers on opaquifying a few more types. A lot of this is going to take fixes in BoringSSL (I skipped a few places where BoringSSL was missing an accessor or we needed const-correctness), but start by switching the easy ones.
|
Ugh. Getting some extremely flaky behavior from gradle (seems the build has some caching bugs?), which is making local testing difficult. Might have to do this by CI. |
|
Okay, that looks a lot better. Windows is unhappy but it looks unrelated. (Although it looks like it may be BoringSSL's fault too. I'll have to take a look at that later.) |
|
Thanks!
Yeah, I noticed something similar the other day but wasn't sure if it was a Gradle bug, our misconfiguration, or I was just holding it wrong.
Yeah, the CI toolchain seems to have updated so now this is an error on Windows: The path of least resistance might be to refactor that but I didn't have time to send you a CL yet. |
prbprbprb
merged commit 571dbaf
into
google:master
FYI: https://boringssl-review.googlesource.com/c/boringssl/+/41844 |
davidben commentedJun 20, 2020
We're starting to chew through the blockers on opaquifying a few more
types. A lot of this is going to take fixes in BoringSSL (I skipped a
few places where BoringSSL was missing an accessor or we needed
const-correctness), but start by switching the easy ones.