Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upClarify that the project argument to client.documents.upload and client.documents.upload_directory is the project ID #120
Comments
ghing
changed the title
|
This is a good point. TBH, the whole project handling bit of this library could use some work. |
|
I hadn't used this library in a while and found it pretty intuitive, except for the expected type or the project argument. I think it's worth a quick documentation fix to ease the pain of other users (or future me). One interesting thing that I realized is that if you changed the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From the API documentation, it's not clear that
projectis the project ID. Since there's aProjectclass, I originally thought this was the type expected for this argument. As seen in #80, others have been confused about whether this argument is the project ID or title.If there's a style of documenting argument types/meaning that you like, I'm happy to submit a pull request.