Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating headers with std::filesystem for Win #1230

Open
simonsan opened this issue Apr 22, 2020 · 3 comments
Open

Updating headers with std::filesystem for Win #1230

simonsan opened this issue Apr 22, 2020 · 3 comments

Comments

@simonsan
Copy link
Contributor

@simonsan simonsan commented Apr 22, 2020

There were some problems in the past regarding std::filesystem, MSVC 2017 and 2019 added support so we would be able to update our sources correspondingly.

std::filesystem for VS2017

@simonsan simonsan added this to todo in windows support via automation Apr 22, 2020
@TheJJ
Copy link
Member

@TheJJ TheJJ commented Apr 22, 2020

I would recommend to replace our custom path handling within libopenage/util/fslike/directory.h to use std::filesystem instead of our custom implementation.
The frontent, our path and filesystem abstraction (openage/util/fslike/ and libopenage/util/fslike/) should stay and then be a wrapper around std::filesystem.

This is because our path system supports passing paths between C++ and Python, and std::filesystem can only be used for native C++ paths.

@sl1g18
Copy link
Contributor

@sl1g18 sl1g18 commented May 3, 2020

I would recommend to replace our custom path handling within libopenage/util/fslike/directory.h to use std::filesystem instead of our custom implementation.
The frontent, our path and filesystem abstraction (openage/util/fslike/ and libopenage/util/fslike/) should stay and then be a wrapper around std::filesystem.

This is because our path system supports passing paths between C++ and Python, and std::filesystem can only be used for native C++ paths.

I think with a bit of support I'll be able to tackle this one as my first contribution :)

@simonsan
Copy link
Contributor Author

@simonsan simonsan commented May 3, 2020

I think with a bit of support I'll be able to tackle this one as my first contribution :)

Nice, and for sure we will be able to support ;-) As a starter you could read a small workflow recommendation by us so here: https://github.com/SFTtech/openage/blob/master/doc/contributing.md#workflow

For example just by making your Draft-PR early and marking it [WIP] we will be able to look easily into things, you and we can comment on lines of code with questions, feedback or explanations etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.