Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdating headers with std::filesystem for Win #1230
Comments
|
I would recommend to replace our custom path handling within This is because our path system supports passing paths between C++ and Python, and |
I think with a bit of support I'll be able to tackle this one as my first contribution :) |
Nice, and for sure we will be able to support ;-) As a starter you could read a small workflow recommendation by us so here: https://github.com/SFTtech/openage/blob/master/doc/contributing.md#workflow For example just by making your Draft-PR early and marking it [WIP] we will be able to look easily into things, you and we can comment on lines of code with questions, feedback or explanations etc. |
There were some problems in the past regarding
std::filesystem, MSVC 2017 and 2019 added support so we would be able to update our sources correspondingly.std::filesystem for VS2017