Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUse sticky table headers #1000
Merged
Use sticky table headers #1000
Conversation
|
|
|
@SKalt THANKS! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Closes #985. I'm pleased to note that sticky table headers are useful in the specification and SDKs page as well.
Notes on the implementation: the
table.table-responsive { display: block }from bootstrap prevented sticky table headers from sticking. I've checked around and I can't notice any adverse effects from moving back to displaying tables as tables, but I'd recommend reviewers check for unexpected side-effects as well.