To my early comment, I guess i was wrong... it seems like the action is running even though the PR came from a fork

https://github.com/nodejs/node/pull/32129/checks?check_run_id=490863314

I thought this was not able to happen based on how GitHub IAM works...

@MylesBorins, it looks like my changes to the actions are running - eg you can see the job running here: https://github.com/nodejs/node/runs/490863314?check_suite_focus=true

@jkleinsc it is only built once in ci-release, specifically on the centos7 machine, I believe. I'm more curious about potential platform issues when building from the source binary. For example there are code paths only for particular architectures / OSs, so would be a shame to miss coverage

My suggestion would be to modify the existing build-* jobs to create the tar balls, extract them somewhere, then run the normal build. Only difficulty with that would be most of the GH action steps assume they're running from the GITHUB_WORKSPACE directory.

The other non-build-* jobs probably need the full git repo contents, and should probably get split out of the single CI.yml with path filtering like #32143 in separate PRs

Codecov Report

Merging #32129 into master will decrease coverage by 0.01%.
The diff coverage is 97.19%.

@@            Coverage Diff             @@
##           master   #32129      +/-   ##
==========================================
- Coverage   97.29%   97.27%   -0.02%     
==========================================
  Files         197      197              
  Lines       64971    65070      +99     
==========================================
+ Hits        63215    63299      +84     
- Misses       1756     1771      +15     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 434d39d...e3b107b. Read the comment docs.

@jkleinsc CI does some setup stuff to choose compiler you don't care about for just x64, and then does:

# get ccache to reuse cache across workspaces
export CCACHE_BASEDIR=$(pwd)

if [ -z ${JOBS+x} ]; then
  export JOBS=$(getconf _NPROCESSORS_ONLN)
fi

...

export NODE_TEST_DIR=${HOME}/node-tmp
export PYTHON=python
export FLAKY_TESTS=dontcare
make run-ci -j $JOBS V=1

Please also consider split into a single file, see #32450.

@jkleinsc This failed on Windows, afaict?

@sam-github any insight into the Windows CI config? I can't get all the tests to pass there and it looks like maybe Jenkins splits the tests into multiple parallel runs?

At least two of the failing tests (parallel/test-source-map-enable and wasi/test-wasi) appear to be failing due to a mismatch in line endings. There's a note in the README for tests saying autocrlf should be set to true in a git checkout on Windows for tests to pass: https://github.com/nodejs/node/tree/master/test#nodejs-core-tests

@richardlau thanks for the hint. That did indeed resolve 2 of the failing tests. It looks like the test parallel/test-child-process-exec-any-shells-windows is still failing though.

For Windows we'll need to add to PATH the path to some basic UNIX tools such as cat, head, sleep as per https://github.com/nodejs/node/blob/master/BUILDING.md#prerequisites

Basic Unix tools required for some tests, Git for Windows includes Git Bash and tools which can be included in the global PATH.

to fix test failures such as:

not ok 39 async-hooks/test-graph.pipe
  ---
  duration_ms: 0.93
  severity: fail
  exitcode: 1
  stack: |-
    events.js:292
          throw er; // Unhandled 'error' event
          ^
    
    Error: spawn sleep ENOENT
        at Process.ChildProcess._handle.onexit (internal/child_process.js:268:19)
        at onErrorNT (internal/child_process.js:468:16)
        at processTicksAndRejections (internal/process/task_queues.js:84:21)
    Emitted 'error' event on ChildProcess instance at:
        at Process.ChildProcess._handle.onexit (internal/child_process.js:274:12)
        at onErrorNT (internal/child_process.js:468:16)
        at processTicksAndRejections (internal/process/task_queues.js:84:21) {
      errno: -4058,
      code: 'ENOENT',
      syscall: 'spawn sleep',
      path: 'sleep',
      spawnargs: [ '0.1' ]
    }

CI: https://ci.nodejs.org/job/node-test-pull-request/30594/

@richardlau this is ready for review. I was able to sort out the Windows issues.

CI: https://ci.nodejs.org/job/node-test-pull-request/30595/ (✔️)

Landed in 38bf1be...26924fa 🎉 Thanks for pushing this through, @jkleinsc!

very nice work, this should be really valuable, thanks for putting up with a marathon @jkleinsc

see: #32848