Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImprove feature provider option descriptions #98
Comments
|
I spotted the following things:
|
|
@exploide Thanks for the review
Good point fixed in #99
I personally don't use
I haven't tried it myself but that's how I interpret the language server docs. We should test it and clear up the docs.
Apart from the the downside you mentioned we had a similar discussion for completions on the It would become impossible for a plugin to add extra formatters. Which was the point of plugins in the first place. For now I tried to keep the config options as close to the language server as possible to avoid additional conversions. But I'm very open to ideas for restructuring our settings. |
|
Good, thanks. Seems like a few points need further investigation. I don't fully understand the thing with the formatters. If there were another plugin that eventually decides to offer formatting functionality (let's say pydocstyle supports formatting in the future), then the language server would need additional code to expose this functionality via the interface implemented by languageclient / ide-ui anyway. Or am I wrong? So changes to the language server (and then in this package) become necessary in every case?! |
People can also install 3rd-party-plugins like the isort-formatter to extend the functionality of the language server. I don't know if we'd be able to support this use case if we implement a custom config. |
At this point the descriptions of the plugin options visible in the Atom settings are rather basic and often less accurate than what can be found in the documentation of the specific feature provider.
We should improve those descriptions and/or link to the relevant docs if applicable.
Any help on this is highly appreciated. This issue doesn't need to be fixed in one go, we can iteratively improve the plugin documentation.