Skip to content

/ react-range

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow click to change with two thumbs #37

Closed
vitalybaev opened this issue Sep 20, 2019 · 3 comments
Closed

Allow click to change with two thumbs #37

vitalybaev opened this issue Sep 20, 2019 · 3 comments
Labels
enhancement good first issue

Comments

@vitalybaev
Copy link
Contributor

@vitalybaev vitalybaev commented Sep 20, 2019

It will be a nice enhancement to have the ability to change values with two thumbs.
I can make this done a bit later. What do you think?

I think it should be work this way:

  1. If click between thumbs - move the closest thumb to the mouse point
  2. If click before the first thumb - move it, else if click after the last thumb - move it. Of course, we should respect rtl.
@tajo
Copy link
Owner

@tajo tajo commented Sep 22, 2019

Sounds good. Could we generalize it for any number of thumbs?
@vitalybaev
Copy link
Contributor Author

@vitalybaev vitalybaev commented Sep 22, 2019

Sure, the first rule works on a click between any thumbs.
@felix-kaestner felix-kaestner mentioned this issue Oct 11, 2020
Merged
@felix-kaestner
Copy link
Contributor

@felix-kaestner felix-kaestner commented Oct 11, 2020

@vitalybaev can you confirm that this Issue was resolved by #95 and is working as expected in the latest release (v1.8.0)?
@tajo tajo closed this Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@vitalybaev @tajo @felix-kaestner
You can’t perform that action at this time.