Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove boost dependency #349
Merged
Conversation
added 2 commits
Sep 3, 2019
|
|
Codecov Report
@@ Coverage Diff @@
## master #349 +/- ##
==========================================
- Coverage 79.77% 79.73% -0.04%
==========================================
Files 110 110
Lines 8565 8565
==========================================
- Hits 6832 6829 -3
- Misses 1733 1736 +3
|
.clang-format
Outdated
| @@ -57,7 +57,6 @@ ExperimentalAutoDetectBinPacking: false | |||
| FixNamespaceComments: false | |||
| ForEachMacros: | |||
| - Q_FOREACH | |||
achamayou
Sep 3, 2019
Member
Do we use Q_FOREACH? That looks like a Qt thing. I assume we can get rid of it too?
eddyashton
Sep 3, 2019
Author
Contributor
Ah, nope. Turns out that removing this messes with formatting of our foreach functions:
static int foreach (lua_State* l)
UD::unbox(l, -2)->foreach ([l, ifunc](const K& k, const V& v)
These are methods where we want without a space (rather than the for () space). It seems that having any value here is sufficient, but I think it's best to leave a useful value (Q_FOREACH) rather than random junk?
eddyashton
Sep 3, 2019
•
Author
Contributor
Have gone with FOREACH rather than suggesting Qt support.
|
|
|
|
added 2 commits
Sep 3, 2019
|
|
eddyashton
pushed a commit
to eddyashton/CCF
that referenced
this pull request
Mar 24, 2020
* Remove boost from ansible * Remove unused boost references * Add dockerignore, remove clang-format Q_FOREACH * Restore Q_FOREACH * Non-specific FOREACH macro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
CCF doesn't depend on Boost - remove it from ansible playbooks, and references elsewhere.