Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeHub crashes if user clicks link to a wiki page in a notification #258

Open
DavidHaslam opened this issue Jan 25, 2017 · 2 comments
Open

CodeHub crashes if user clicks link to a wiki page in a notification #258

DavidHaslam opened this issue Jan 25, 2017 · 2 comments
Labels
bug
Milestone

Comments

@DavidHaslam
Copy link

@DavidHaslam DavidHaslam commented Jan 25, 2017

One of the notifications I received today was for an edit to a wiki page in another repository.

When I clicked the blue highlighted linked name of the wiki page, CodeHub just closed.

Even though GitHub doesn't provide API for its wiki feature, clearly the addresses of such pages can arise in notifications, events, etc, and are parsed by CodeHub as links, even though it has no method handle them if they are clicked.

@thedillonb thedillonb added the bug label Feb 13, 2017
@thedillonb thedillonb added this to the 2.10 milestone Feb 13, 2017
@thedillonb
Copy link
Collaborator

@thedillonb thedillonb commented May 2, 2017

I can't seem to reproduce this. I've generated Wiki events that show up in the "News" view and then clicking on the link to the wiki page. All that occurs, like it should, is that a in-app web browser appears and sends you to the wiki page (cause, like you mentioned, GitHub has no Wiki API)

kapture 2017-05-01 at 22 33 16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@thedillonb @DavidHaslam and others
You can’t perform that action at this time.