Skip to content

/ yarn

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yarn audit does not work with an external repository #7012

Open
adamscybot opened this issue Feb 7, 2019 · 4 comments
Open

Yarn audit does not work with an external repository #7012

adamscybot opened this issue Feb 7, 2019 · 4 comments
Labels
good first issue help wanted

Comments

@adamscybot
Copy link

@adamscybot adamscybot commented Feb 7, 2019 •
edited

Do you want to request a feature or report a bug?
Bug

What is the current behavior?

When running yarn audit with the --registry flag, it uses the main yarn repo anyway.

If the current behavior is a bug, please provide the steps to reproduce.

Execute yarn audit --registry https://registry.npmjs.org/

What is the expected behavior?

Audit calls are made to the defined registry. This is especially important for everyone with third party repo's where the outside world it blocked on CI agents. Or if you're using some kind of proxy.

Please mention your node.js, yarn and operating system version.

Mac Os Mojave
Yarn 1.13.0
Node 10.15.1
@abhisheksoni27

This comment has been minimized.

Sign in to view
Copy link

@abhisheksoni27 abhisheksoni27 commented Feb 17, 2019 •
edited

What exactly is happening on LINE 217 ?

yarn/src/cli/commands/audit.js

Lines 211 to 225 in 0f05203

async _fetchAudit(auditTree: AuditTree): Object {
let responseJson;
const registry = YARN_REGISTRY;
this.reporter.verbose(`Audit Request: ${JSON.stringify(auditTree, null, 2)}`);
const requestBody = await gzip(JSON.stringify(auditTree));
const response = await this.config.requestManager.request({
url: `${registry}/-/npm/v1/security/audits`,
method: 'POST',
body: requestBody,
headers: {
'Content-Encoding': 'gzip',
'Content-Type': 'application/json',
Accept: 'application/json',
},
});

Do you have an endpoint configured that automatically calls npm's audit registry ?
@quinnturner quinnturner mentioned this issue Mar 6, 2019
Merged
@gaiazov

This comment has been minimized.

Sign in to view
Copy link

@gaiazov gaiazov commented May 9, 2019

@abhisheksoni27 on line 217 the YARN_REGISTRY constant is used, which corresponds to https://registry.yarnpkg.com

yarn/src/constants.js

Line 21 in 0f05203

export const YARN_REGISTRY = 'https://registry.yarnpkg.com';

@charlyx charlyx mentioned this issue May 11, 2019
Open
@pratyushj

This comment has been minimized.

Sign in to view
Copy link

@pratyushj pratyushj commented Jul 11, 2019

Hey, can I try to solve this bug?
@quinnturner quinnturner mentioned this issue Sep 2, 2019
Open
@eugenesimakin

This comment has been minimized.

Sign in to view
Copy link

@eugenesimakin eugenesimakin commented Sep 5, 2019

Hi @pratyushj, the issue already has its PR #7263. Thanks!
In addition to that, it has a duplicate PR #6484
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
@adamscybot @abhisheksoni27 @gaiazov @pratyushj @eugenesimakin @rally25rs
You can’t perform that action at this time.