Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a test suite to the examples repo that ensures the examples are working after each framework release #312

Open
brianneisler opened this issue Oct 23, 2018 · 1 comment
Labels

Comments

@brianneisler
Copy link

@brianneisler brianneisler commented Oct 23, 2018

Would be good to ensure that examples are working as expected after each new release of the framework. It's very easy for examples to go out of date or break over time if they're not monitored.

@brianneisler brianneisler changed the title add a test suite to the examples repo that ensures the examples are working after each release add a test suite to the examples repo that ensures the examples are working after each framework release Oct 23, 2018
@brianneisler
Copy link
Author

@brianneisler brianneisler commented Oct 24, 2018

Thinking that we just need the appropriate harness in place to run a CI build when framework master is updated. That’s a bit different than the usual practice of running when the examples repo is updated

One way we might do this is by adding the framework as a submodule of examples. This might trigger a build on examples anytime master is updated on framework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.