Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zh-cn: improve grammar and add translation #736

Merged
merged 1 commit into from Mar 3, 2020

Conversation

@lynkas
Copy link
Contributor

@lynkas lynkas commented Feb 25, 2020

Overview

TL;DR
improved grammar, and finished translation in zh-cn.

Questions

some format has been changed (like introduction) due to subtitle (or introduction) is difficult to be splited from the body.

Next Steps

<If incomplete, create a task list of items that are still being worked on within the Pull Request.>

Review

<If complete, or ready for 👀, use @mentions for quick questions, specific feedback, and progress updates.>

@brianamarie
Copy link
Contributor

@brianamarie brianamarie commented Mar 3, 2020

Thank you for this contribution, @lynkas!

@brianamarie brianamarie merged commit e686047 into github:master Mar 3, 2020
@@ -16,39 +16,39 @@ leadingpath: ../../../
[git-scm.com](https://git-scm.com)

## 配置工具
对所有本地仓库的用户信息进行配置
##### 对所有本地仓库的用户信息进行配置

This comment has been minimized.

@imba-tjd

imba-tjd Jun 9, 2020
Contributor

@lynkas I don't think this is appropriate. The translation should respect the original format. Besides you shouldn't use h5 directly under h2. If you want an emphasis, ** is to be used.

This comment has been minimized.

@brianamarie

brianamarie Jun 10, 2020
Contributor

It appears #752 is open to address this 👍 Thank you @imba-tjd!

brianamarie pushed a commit that referenced this pull request Jun 23, 2020
* zh-cn: partially revert 736 and sync with en

* Update github-git-cheat-sheet.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.