Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upesm: data URLs should ignore unknown parameters #30593
Closed
Conversation
|
Great, thank you. |
This comment has been minimized.
This comment has been minimized.
|
For reference (from the original PR) — https://gist.github.com/SMotaal/2e0ede8c6115b828c111fa84a1e952b4 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
CI error is on waiting for AIX executor timeout, looks good to merge in a few |
bmeck
pushed a commit
that referenced
this pull request
Nov 26, 2019
This comment has been minimized.
This comment has been minimized.
|
Landed in 568968e |
addaleax
added a commit
that referenced
this pull request
Nov 30, 2019
Merged
MylesBorins
added a commit
that referenced
this pull request
Jan 12, 2020
PR-URL: #30593 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com>
BethGriggs
added a commit
that referenced
this pull request
Feb 6, 2020
PR-URL: #30593 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com>
Merged
saitonakamura
pushed a commit
to saitonakamura/node
that referenced
this pull request
Apr 7, 2020
PR-URL: nodejs#30593 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
bmeck commentedNov 22, 2019
The
data:URL implementation was overly strict about what MIMEs it accepted. This caused problems for people using parameters. This relaxes the restrictions and follows the MIME expectation of ignoring unknown parameters. Per RFC2045:This also matches the WHATWG handling of
data:URLs by using any,as the splitting point.CC: @nodejs/modules
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes