Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repl: add autocomplete support for fs.promises #29400

Closed
wants to merge 1 commit into from
Closed

repl: add autocomplete support for fs.promises #29400

wants to merge 1 commit into from

Conversation

antsmartian
Copy link
Contributor

@antsmartian antsmartian commented Sep 2, 2019 •
edited

Follow up of this #26648. Adding support for fs.promises also updated the test files.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@antsmartian
Copy link
Contributor Author

@antsmartian antsmartian commented Sep 2, 2019

ping @nodejs/repl

jasnell
jasnell approved these changes Sep 3, 2019
View changes
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Sep 5, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/25359/

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Sep 5, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/25363/

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Sep 5, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/25364/

BridgeAR
BridgeAR approved these changes Sep 5, 2019
View changes
Copy link
Member

@BridgeAR BridgeAR left a comment

LGTM % nits

test/parallel/test-repl-tab-complete.js Outdated Show resolved Hide resolved
lib/repl.js Outdated Show resolved Hide resolved
@Trott Trott removed the author ready label Sep 7, 2019
@Trott
Copy link
Member

@Trott Trott commented Sep 7, 2019

Removed author ready because there are nits. This can still land as the nits here look optional, but they seem like good suggestions I think so might as well?

addaleax
addaleax approved these changes Sep 7, 2019
View changes
Copy link
Member

@addaleax addaleax left a comment

LGTM, I’m okay with fixing the nits while landing or separately

@antsmartian
Copy link
Contributor Author

@antsmartian antsmartian commented Sep 10, 2019

Ping @addaleax @BridgeAR . Addressed nits.. Could you please have a look at this now?

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Sep 10, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/25414/

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Sep 10, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/25415/

ZYSzys
ZYSzys approved these changes Sep 15, 2019
View changes
@Trott
Copy link
Member

@Trott Trott commented Sep 16, 2019

Landed in ed0e5c8

Trott added a commit that referenced this issue Sep 16, 2019
@antsmartian @Trott
repl: add autocomplete support for fs.promises
ed0e5c8 
PR-URL: #29400
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@Trott Trott closed this Sep 16, 2019
targos added a commit that referenced this issue Sep 20, 2019
@antsmartian @targos
repl: add autocomplete support for fs.promises
d57d47b 
PR-URL: #29400
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Sep 24, 2019
Merged
BridgeAR added a commit that referenced this issue Sep 25, 2019
@antsmartian @BridgeAR
repl: add autocomplete support for fs.promises
596dd9f 
PR-URL: #29400
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@beevelop beevelop mentioned this pull request Sep 25, 2019
Closed
@beevelop beevelop mentioned this pull request Sep 25, 2019
Closed
@beevelop beevelop mentioned this pull request Sep 26, 2019
Closed
@beevelop beevelop mentioned this pull request Sep 26, 2019
Closed
@beevelop beevelop mentioned this pull request Sep 26, 2019
Closed
@beevelop beevelop mentioned this pull request Sep 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell

@addaleax addaleax

@BridgeAR BridgeAR

@ZYSzys ZYSzys

Assignees
No one assigned
Labels
author ready repl
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet
7 participants
@antsmartian @nodejs-github-bot @Trott @jasnell @addaleax @BridgeAR @ZYSzys