Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: simplify drain #29081

Closed
wants to merge 1 commit into from

Conversation

@ronag
Copy link
Contributor

commented Aug 11, 2019 •
edited

Simplify and slightly optimize draining outgoing http streams.

Avoid extra event listener and inline with rest of the drain logic.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

NOTE TO SELF: After this is merged add destroyed and ensure 'drain' is not emitted after destroy(). Also look into removing unnecessary flush class in write.

@nodejs-github-bot nodejs-github-bot added the lib / src label Aug 11, 2019

@mscdex

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Aug 11, 2019

I think we should be using a symbol instead of an underscore-prefixed property.

@ronag ronag force-pushed the nxtedition:http-simplify-drain branch from 078268c to 054d050 Aug 11, 2019

@ronag

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Aug 11, 2019

@mscdex: fixed

@ronag ronag force-pushed the nxtedition:http-simplify-drain branch 7 times, most recently from e82d80e to a6486de Aug 11, 2019

@mscdex
mscdex reviewed Aug 11, 2019
View changes
lib/_http_outgoing.js Outdated Show resolved Hide resolved

@ronag ronag force-pushed the nxtedition:http-simplify-drain branch 4 times, most recently from e9184d5 to 35ba9c3 Aug 11, 2019

@mscdex
mscdex reviewed Aug 11, 2019
View changes
lib/_http_client.js Outdated Show resolved Hide resolved

@ronag ronag force-pushed the nxtedition:http-simplify-drain branch 3 times, most recently from 2a6fb63 to 41a0458 Aug 12, 2019

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

commented Aug 13, 2019

@nodejs/http
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

commented Aug 16, 2019

@ronag Can you give this a rebase to get rid of the conflicts?

@nodejs/collaborators @nodejs/streams This could use some reviews.

@ronag ronag force-pushed the nxtedition:http-simplify-drain branch from 41a0458 to dcca00f Aug 17, 2019

@ronag

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Aug 17, 2019

@Trott fixed
@ronag
http: simplify drain
Loading status checks…
73e760f

@ronag ronag force-pushed the nxtedition:http-simplify-drain branch from dcca00f to 73e760f Aug 17, 2019

@mcollina
mcollina approved these changes Aug 19, 2019
View changes
Copy link
Member

left a comment

LGTM
lib/_http_outgoing.js Show resolved Hide resolved
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Aug 19, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/25085/
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Aug 19, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/25106/
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

commented Aug 19, 2019

Landed in bdf07f4

@Trott Trott closed this Aug 19, 2019

Trott added a commit that referenced this pull request Aug 19, 2019
@ronag @Trott
http: simplify drain() 
Simplify and slightly optimize draining outgoing http streams. Avoid
extra event listener and inline with rest of the drain logic.

PR-URL: #29081
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Loading status checks…
bdf07f4
targos added a commit that referenced this pull request Aug 20, 2019
@ronag @targos
http: simplify drain() 
Simplify and slightly optimize draining outgoing http streams. Avoid
extra event listener and inline with rest of the drain logic.

PR-URL: #29081
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
c5edeb9
@targos targos referenced this pull request Aug 20, 2019
Merged
This was referenced Aug 20, 2019
Closed
Closed
Closed
Closed
Closed
Closed
@targos targos referenced this pull request Aug 21, 2019
Closed

@Trott Trott added dont-land-on-v10.x dont-land-on-v8.x labels Aug 21, 2019

JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
@ronag @JeniaBR
http: simplify drain() 
Simplify and slightly optimize draining outgoing http streams. Avoid
extra event listener and inline with rest of the drain logic.

PR-URL: nodejs#29081
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
a5629a2
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
@ronag @JeniaBR
http: simplify drain() 
Simplify and slightly optimize draining outgoing http streams. Avoid
extra event listener and inline with rest of the drain logic.

PR-URL: nodejs#29081
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
cafb732
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mscdex mscdex

@mcollina mcollina

Assignees
No one assigned
Labels
dont-land-on-v10.x dont-land-on-v8.x lib / src
Projects
None yet
Milestone
No milestone
5 participants
@ronag @mscdex @Trott @nodejs-github-bot @mcollina
You can’t perform that action at this time.