Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix introduced_in note in querystring.md #29014

Closed
wants to merge 1 commit into from

Conversation

@bnoordhuis
Copy link
Member

commented Aug 6, 2019

The method descriptions mentioned the right version but for some reason
the top-level description did not. Well, now it does.
@bnoordhuis
doc: fix introduced_in note in querystring.md 
The method descriptions mentioned the right version but for some reason
the top-level description did not. Well, now it does.
Loading status checks…
c514631

@nodejs-github-bot nodejs-github-bot added doc querystring labels Aug 6, 2019

@cjihrig
cjihrig approved these changes Aug 6, 2019
View changes
@trivikr
trivikr approved these changes Aug 6, 2019
View changes
@lpinca
lpinca approved these changes Aug 6, 2019
View changes
@jasnell
jasnell approved these changes Aug 7, 2019
View changes
@danbev

This comment has been minimized.

Sign in to view
Copy link
Member

commented Aug 16, 2019 •
edited

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3832/ (✔️)
@danbev

This comment has been minimized.

Sign in to view
Copy link
Member

commented Aug 16, 2019

Landed in 0f8f4cd.

@danbev danbev closed this Aug 16, 2019

danbev added a commit that referenced this pull request Aug 16, 2019
@bnoordhuis @danbev
doc: fix introduced_in note in querystring.md 
The method descriptions mentioned the right version but for some reason
the top-level description did not. Well, now it does.

PR-URL: #29014
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Loading status checks…
0f8f4cd
targos added a commit that referenced this pull request Aug 19, 2019
@bnoordhuis @targos
doc: fix introduced_in note in querystring.md 
The method descriptions mentioned the right version but for some reason
the top-level description did not. Well, now it does.

PR-URL: #29014
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
8f8136c
targos added a commit that referenced this pull request Aug 19, 2019
@bnoordhuis @targos
doc: fix introduced_in note in querystring.md 
The method descriptions mentioned the right version but for some reason
the top-level description did not. Well, now it does.

PR-URL: #29014
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
ebfe636
@targos targos referenced this pull request Aug 19, 2019
Merged
This was referenced Aug 20, 2019
Closed
Closed
Closed
Closed
Closed
Closed
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
@bnoordhuis @JeniaBR
doc: fix introduced_in note in querystring.md 
The method descriptions mentioned the right version but for some reason
the top-level description did not. Well, now it does.

PR-URL: nodejs#29014
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
0070eff
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
@bnoordhuis @JeniaBR
doc: fix introduced_in note in querystring.md 
The method descriptions mentioned the right version but for some reason
the top-level description did not. Well, now it does.

PR-URL: nodejs#29014
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
29c3d76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell

@lpinca lpinca

@cjihrig cjihrig

@trivikr trivikr

Assignees
No one assigned
Labels
doc querystring
Projects
None yet
Milestone
No milestone
7 participants
@bnoordhuis @danbev @jasnell @lpinca @cjihrig @trivikr @nodejs-github-bot
You can’t perform that action at this time.