crypto: extend RSA-OAEP support with oaepHash #28335

tniessen · Jun 21, 2019

This adds an oaepHash option to asymmetric encryption which allows users to specify a hash function when using OAEP padding. This feature is required for interoperability with WebCrypto applications.

Fixes: #25756

cc @nodejs/crypto @sam-github @panva

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines


      crypto: extend RSA-OAEP support with oaepHash

This adds an oaepHash option to asymmetric encryption which allows
users to specify a hash function when using OAEP padding. This
feature is required for interoperability with WebCrypto applications.

panva · Jun 21, 2019

I'll give the branch it a try!

Quick note, it would be great if the "support" for this was detectable, other than semver checking the process node version or trying and failing of course. If it would even fail with an unrecognized option.

panva · 2019-06-21T20:57:27Z

panva reviewed

Jun 21, 2019

View changes

doc/api/crypto.md

panva · 2019-06-21T20:57:41Z

panva reviewed

Jun 21, 2019

View changes

doc/api/crypto.md

bnoordhuis · 2019-06-22T09:37:17Z

bnoordhuis approved these changes

Jun 22, 2019

View changes

BridgeAR · 2019-06-22T17:32:38Z

BridgeAR reviewed

Jun 22, 2019

View changes

doc/api/crypto.md


      fixup! crypto: extend RSA-OAEP support with oaepHash

panva · 2019-06-23T08:40:07Z

panva approved these changes

Jun 23, 2019

View changes

tniessen · Jun 23, 2019

Quick note, it would be great if the "support" for this was detectable, other than semver checking the process node version or trying and failing of course.

We don't have a unified approach for this yet.

If it would even fail with an unrecognized option.

We cannot patch this into existing Node.js releases, and I don't think we would if we could. It would most likely be a breaking change.

jasnell · 2019-06-23T18:35:22Z

jasnell approved these changes

Jun 23, 2019

View changes

sam-github · 2019-06-24T18:29:28Z

sam-github reviewed

Jun 24, 2019

View changes

doc/api/crypto.md

src/node_crypto.cc

test/parallel/test-crypto-rsa-dsa.js

sam-github · Jun 24, 2019

I think we should somehow mark node as supporting this new API. Backporting the throwing of errors is not possible, as you say, but some constant could be exported for crypto that could be checked for existence, that would be helpful. As-is, I think that it can only be detected by a fragile comparison against node version (fragile because as the feature is backported the comparison needs changing), or a speculative RSA key gen and encrypt then decrypt operation (using decrypt failure to indicate a mismatch of digest algs).

Btw, did you consider allowing the OAEP digest to be set as a property of the private key, with EVP_PKEY_CTX_set_rsa_oaep_md()/an-option-to-key-object-creation? Of would that be not as useful as doing it at time of encrypt/decrypt?

panva · Jun 24, 2019

I think we should somehow mark node as supporting this new API.

Maybe something to the effect of crypto.constants.RSA_PKCS1_PSS_PADDING and the like that is used to detect PSS support.

panva · Jun 24, 2019

Btw, did you consider allowing the OAEP digest to be set as a property of the private key, with EVP_PKEY_CTX_set_rsa_oaep_md()/an-option-to-key-object-creation? Of would that be not as useful as doing it at time of encrypt/decrypt?

Binding this to a key object would definitely be an obstacle for re-using the same key for different decryption schemes. I prefer an encrypt/decrypt option like this, very useful, very flexible.

tniessen · Jun 24, 2019

I think we should somehow mark node as supporting this new API.

I agree, but I don't think we should use ad hoc solutions for something as important as feature detection. The same problem exists for many, many other features (CCM, OCB, RSA-PSS, PEM-level encryption, GCM validation, ...), and that's only counting crypto.

Btw, did you consider allowing the OAEP digest to be set as a property of the private key, with EVP_PKEY_CTX_set_rsa_oaep_md()/an-option-to-key-object-creation? Of would that be not as useful as doing it at time of encrypt/decrypt?

I did, but then we'd have to add the padding to the key object as well. I am not necessarily opposed to that, but it would add a lot of complexity to KeyObject.

Binding this to a key object would definitely be an obstacle for re-using the same key for different decryption schemes.

Side note: Not being able to do that is considered good design by many cryptographers. It is often considered bad practice to use the same key for different algorithms.

panva · Jun 24, 2019

I know. In this case the same exposed public RSA JWK is used to encrypt messages with JWA RSA1_5 or RSA-OAEP(-256) and the recipient decrypts those. Were it vice versa i wouldn’t mention it.

For instance: An OAuth 2 exposes the public key and accepts confidental signed and encrypted authorization requests from many relying parties. These may use different JWAs.

sam-github · Jun 24, 2019

Using crypto constants for feature detection is pretty common, we do it lots of places. Its how TLS1.3 is detected, and I assume the existence of crypto.constants.RSA_PKCS1_OAEP_PADDING can also be used to detect support for OAEP, but not of support for this new oaepHash option. We'd be better off in some ways if a magic value had to be set in oaepHash, like crypto.RSA_PKCS1_OAEP_PADDING_SHA1, because then it would be testable for, but I'm not really suggesting that. Hm, unless we should do it? What happends when 'md2' is used as a digest? They (hopefully) are not all supported. Maybe exposing constants would allow testing for what digests are supported?

I think it would be consistent to add a constant, for example crypto.RSA_PKCS1_OAEP_PADDING_CONFIGURABLE = true, for feature detection, and I don't think we should not do it because we lack some kind of global Node.js feature registry.

tniessen · Jul 12, 2019

@sam-github Sorry for the late reply, I appreciate your concerns.

What happends when 'md2' is used as a digest? They (hopefully) are not all supported. Maybe exposing constants would allow testing for what digests are supported?

All hash functions returned by crypto.getHashes() are accepted by OpenSSL. (md2 is not supported on master.)

We'd be better off in some ways if a magic value had to be set in oaepHash, like crypto.RSA_PKCS1_OAEP_PADDING_SHA1, because then it would be testable for, but I'm not really suggesting that.

True, it would help, but it would be inconsistent with other APIs that accept hash functions, and since all hash functions are accepted by OpenSSL, we would either have to manually restrict that or add constants for all hash functions.

I think it would be consistent to add a constant, for example crypto.RSA_PKCS1_OAEP_PADDING_CONFIGURABLE = true, for feature detection, and I don't think we should not do it because we lack some kind of global Node.js feature registry.

That would make feature detection more difficult in ESM since undefined "constants" cannot be imported, yet this alone would only be a minor inconvenience and could be "solved" by adding the constant to crypto.constants instead. I can add such a constant to crypto or crypto.constants if you would like. Personally, I think it is neither consistent nor an elegant or very "JavaScript-ish" solution.

panva · Jul 12, 2019

Personally, I think it is neither consistent nor an elegant or very "JavaScript-ish" solution.

Neither is this and it doesn't account for backports or custom builds.

const [major, minor] = process.version.substr(1).split('.').map(x => parseInt(x, 10))

if (major > 12 || (major === 12 && minor >= xx) {
 // yay support!
}

crypto.constants seems to me like a consistent way for crypto "options object" feature discovery for existing APIs, we already use it for RSASSA-PSS.

tniessen · Jul 18, 2019

Personally, I think it is neither consistent nor an elegant or very "JavaScript-ish" solution.

Neither is this and it doesn't account for backports or custom builds.

@panva That does not contradict what I said. As I wrote before, I can add such a constant, but that does not change the fact that I don't think it is an elegant solution.

I would like to hear Sam's opinion on this. If he is in favor of such a constant, I'll add it and proceed to land this.

panva · Jul 19, 2019

@tniessen not trying to contradict ;) just saying we already have a kind of established way in crypto.constants

sam-github · Jul 22, 2019

The crypto module by exposing OpenSSL macro/constants allows (sometimes) feature detection in the "C" style of OpenSSL. I'm not suggesting its elegant :-), but I think its consistent with OpenSSL and at least some current crypto features, and that its useful.

Are you sure none of CCM, OCB, RSA-PSS, PEM-level encryption, GCM validation are detectable using contants? I think RSA_PKCS1_PSS_PADDING exists for PSS, and getCiphers() can be used to look for CCM and gcm ciphers. OCB and PEM-level enc I don't know how to detect.

If @panva and others find it impossible to detect the existence of the feature, the feature might not be used, which would be a shame. Note that a hard coded dependency on node > 12.x.y (where x.y is where it was released) would fail to detect backports, so would assume it was unsupported even if it was. But at this time, 10.x is so far behind that maybe this will never backport, so that's OK.

I will do some thinking of a more general purpose feature detection system for Node.js, but that won't happen fast, if ever.

If you can't think of an OpenSSL (or OpenSSL-like) constant you'd like to expose to indicate the feature's existence (or the XOF variable length feature, which is in the same category), lets get this landed.

sam-github · 2019-07-22T18:30:56Z

sam-github approved these changes

Jul 22, 2019

View changes

panva · 2019-07-22T20:28:51Z

panva approved these changes

Jul 22, 2019

View changes


      crypto: extend RSA-OAEP support with oaepHash

This adds an oaepHash option to asymmetric encryption which allows
users to specify a hash function when using OAEP padding. This
feature is required for interoperability with WebCrypto applications.

PR-URL: #28335
Fixes: #25756
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>


      test: add test for OAEP hash mismatch

PR-URL: #28335
Fixes: #25756
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>


      2019-08-20, Version 12.9.0 (Current)

Notable changes:

* **crypto**:
  * Added an oaepHash option to asymmetric encryption which allows users to specify a hash function when using OAEP padding (Tobias Nießen) [#28335](#28335).
* **deps**:
  * Updated V8 to 7.6.303.29 (Michaël Zasso) [#28955](#28955).
    * Improves the performance of various APIs such as `JSON.parse` and methods
      called on frozen arrays.
    * Adds the [`Promise.allSettled`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/allSettled) method.
    * Improves support of `BigInt` in `Intl` methods.
    * For more information: https://v8.dev/blog/v8-release-76
  * Updated libuv to 1.31.0 (cjihrig) [#29070](#29070).
    * `UV_FS_O_FILEMAP` has been added for faster access to memory mapped files on Windows.
    * `uv_fs_mkdir()` now returns `UV_EINVAL` for invalid filenames on Windows. It previously returned `UV_ENOENT`.
    * The `uv_fs_statfs()` API has been added.
    * The `uv_os_environ()` and `uv_os_free_environ()` APIs have been added.
* **fs**:
  * Added `fs.writev` and `fs.writevSync` methods. They allow to write an array of `ArrayBufferView`s to a file descriptor (Anas Aboureada) [#25925](#25925).
* **http**:
  * Added three properties to `OutgoingMessage.prototype`: `writableObjectMode`, `writableLength` and `writableHighWaterMark` [#29018](#29018).
* **stream**:
  * Added an new property `writableEnded` to writable streams. Its value is set to `true` after `writable.end()` has been called. (Robert Nagy) [#28934](#28934).

PR-URL: #29209


      crypto: extend RSA-OAEP support with oaepHash

This adds an oaepHash option to asymmetric encryption which allows
users to specify a hash function when using OAEP padding. This
feature is required for interoperability with WebCrypto applications.

PR-URL: #28335
Fixes: #25756
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>


      test: add test for OAEP hash mismatch

PR-URL: #28335
Fixes: #25756
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>


      2019-08-20, Version 12.9.0 (Current)

Notable changes:

* **crypto**:
  * Added an oaepHash option to asymmetric encryption which allows users to specify a hash function when using OAEP padding (Tobias Nießen) [#28335](#28335).
* **deps**:
  * Updated V8 to 7.6.303.29 (Michaël Zasso) [#28955](#28955).
    * Improves the performance of various APIs such as `JSON.parse` and methods
      called on frozen arrays.
    * Adds the [`Promise.allSettled`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/allSettled) method.
    * Improves support of `BigInt` in `Intl` methods.
    * For more information: https://v8.dev/blog/v8-release-76
  * Updated libuv to 1.31.0 (cjihrig) [#29070](#29070).
    * `UV_FS_O_FILEMAP` has been added for faster access to memory mapped files on Windows.
    * `uv_fs_mkdir()` now returns `UV_EINVAL` for invalid filenames on Windows. It previously returned `UV_ENOENT`.
    * The `uv_fs_statfs()` API has been added.
    * The `uv_os_environ()` and `uv_os_free_environ()` APIs have been added.
* **fs**:
  * Added `fs.writev` and `fs.writevSync` methods. They allow to write an array of `ArrayBufferView`s to a file descriptor (Anas Aboureada) [#25925](#25925).
* **http**:
  * Added three properties to `OutgoingMessage.prototype`: `writableObjectMode`, `writableLength` and `writableHighWaterMark` [#29018](#29018).
* **stream**:
  * Added an new property `writableEnded` to writable streams. Its value is set to `true` after `writable.end()` has been called. (Robert Nagy) [#28934](#28934).

PR-URL: #29209


      2019-08-20, Version 12.9.0 (Current)

Notable changes:

* **crypto**:
  * Added an oaepHash option to asymmetric encryption which allows users to specify a hash function when using OAEP padding (Tobias Nießen) [#28335](#28335).
* **deps**:
  * Updated V8 to 7.6.303.29 (Michaël Zasso) [#28955](#28955).
    * Improves the performance of various APIs such as `JSON.parse` and methods
      called on frozen arrays.
    * Adds the [`Promise.allSettled`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/allSettled) method.
    * Improves support of `BigInt` in `Intl` methods.
    * For more information: https://v8.dev/blog/v8-release-76
  * Updated libuv to 1.31.0 (cjihrig) [#29070](#29070).
    * `UV_FS_O_FILEMAP` has been added for faster access to memory mapped files on Windows.
    * `uv_fs_mkdir()` now returns `UV_EINVAL` for invalid filenames on Windows. It previously returned `UV_ENOENT`.
    * The `uv_fs_statfs()` API has been added.
    * The `uv_os_environ()` and `uv_os_free_environ()` APIs have been added.
* **fs**:
  * Added `fs.writev` and `fs.writevSync` methods. They allow to write an array of `ArrayBufferView`s to a file descriptor (Anas Aboureada) [#25925](#25925).
* **http**:
  * Added three properties to `OutgoingMessage.prototype`: `writableObjectMode`, `writableLength` and `writableHighWaterMark` [#29018](#29018).
* **stream**:
  * Added an new property `writableEnded` to writable streams. Its value is set to `true` after `writable.end()` has been called. (Robert Nagy) [#28934](#28934).

PR-URL: #29210


      2019-08-20, Version 12.9.0 (Current)

Notable changes:

* crypto:
  * Added an oaepHash option to asymmetric encryption which allows
    users to specify a hash function when using OAEP padding.
    #28335
* deps:
  * Updated V8 to 7.6.303.29. #28955
    * Improves the performance of various APIs such as `JSON.parse` and
      methods called on frozen arrays.
    * Adds the Promise.allSettled method.
    * Improves support of `BigInt` in `Intl` methods.
    * For more information: https://v8.dev/blog/v8-release-76
  * Updated libuv to 1.31.0. #29070
    * `UV_FS_O_FILEMAP` has been added for faster access to memory
      mapped files on Windows.
    * `uv_fs_mkdir()` now returns `UV_EINVAL` for invalid filenames on
      Windows. It previously returned `UV_ENOENT`.
    * The `uv_fs_statfs()` API has been added.
    * The `uv_os_environ()` and `uv_os_free_environ()` APIs have been
      added.
* fs:
  * Added `fs.writev`, `fs.writevSync` and `filehandle.writev` (promise
    version) methods. They allow to write an array of `ArrayBufferView`s
    to a file descriptor. #25925
    https://github.com/nodejs/node/pull/29186/files
* http:
  * Added three properties to `OutgoingMessage.prototype`:
    `writableObjectMode`, `writableLength` and `writableHighWaterMark`
    #29018
* stream:
  * Added an new property `readableEnded` to readable streams. Its value
    is set to `true` when the `'end'` event is emitted.
    #28814
  * Added an new property `writableEnded` to writable streams. Its value
    is set to `true` after `writable.end()` has been called.
    #28934

PR-URL: #29210


      2019-08-20, Version 12.9.0 (Current)

Notable changes:

* crypto:
  * Added an oaepHash option to asymmetric encryption which allows
    users to specify a hash function when using OAEP padding.
    #28335
* deps:
  * Updated V8 to 7.6.303.29. #28955
    * Improves the performance of various APIs such as `JSON.parse` and
      methods called on frozen arrays.
    * Adds the Promise.allSettled method.
    * Improves support of `BigInt` in `Intl` methods.
    * For more information: https://v8.dev/blog/v8-release-76
  * Updated libuv to 1.31.0. #29070
    * `UV_FS_O_FILEMAP` has been added for faster access to memory
      mapped files on Windows.
    * `uv_fs_mkdir()` now returns `UV_EINVAL` for invalid filenames on
      Windows. It previously returned `UV_ENOENT`.
    * The `uv_fs_statfs()` API has been added.
    * The `uv_os_environ()` and `uv_os_free_environ()` APIs have been
      added.
* fs:
  * Added `fs.writev`, `fs.writevSync` and `filehandle.writev` (promise
    version) methods. They allow to write an array of `ArrayBufferView`s
    to a file descriptor. #25925
    https://github.com/nodejs/node/pull/29186/files
* http:
  * Added three properties to `OutgoingMessage.prototype`:
    `writableObjectMode`, `writableLength` and `writableHighWaterMark`
    #29018
* stream:
  * Added an new property `readableEnded` to readable streams. Its value
    is set to `true` when the `'end'` event is emitted.
    #28814
  * Added an new property `writableEnded` to writable streams. Its value
    is set to `true` after `writable.end()` has been called.
    #28934

PR-URL: #29210


      2019-08-20, Version 12.9.0 (Current)

Notable changes:

* crypto:
  * Added an oaepHash option to asymmetric encryption which allows
    users to specify a hash function when using OAEP padding.
    nodejs#28335
* deps:
  * Updated V8 to 7.6.303.29. nodejs#28955
    * Improves the performance of various APIs such as `JSON.parse` and
      methods called on frozen arrays.
    * Adds the Promise.allSettled method.
    * Improves support of `BigInt` in `Intl` methods.
    * For more information: https://v8.dev/blog/v8-release-76
  * Updated libuv to 1.31.0. nodejs#29070
    * `UV_FS_O_FILEMAP` has been added for faster access to memory
      mapped files on Windows.
    * `uv_fs_mkdir()` now returns `UV_EINVAL` for invalid filenames on
      Windows. It previously returned `UV_ENOENT`.
    * The `uv_fs_statfs()` API has been added.
    * The `uv_os_environ()` and `uv_os_free_environ()` APIs have been
      added.
* fs:
  * Added `fs.writev`, `fs.writevSync` and `filehandle.writev` (promise
    version) methods. They allow to write an array of `ArrayBufferView`s
    to a file descriptor. nodejs#25925
    https://github.com/nodejs/node/pull/29186/files
* http:
  * Added three properties to `OutgoingMessage.prototype`:
    `writableObjectMode`, `writableLength` and `writableHighWaterMark`
    nodejs#29018
* stream:
  * Added an new property `readableEnded` to readable streams. Its value
    is set to `true` when the `'end'` event is emitted.
    nodejs#28814
  * Added an new property `writableEnded` to writable streams. Its value
    is set to `true` after `writable.end()` has been called.
    nodejs#28934

PR-URL: nodejs#29210


      2019-08-20, Version 12.9.0 (Current)

Notable changes:

* crypto:
  * Added an oaepHash option to asymmetric encryption which allows
    users to specify a hash function when using OAEP padding.
    #28335
* deps:
  * Updated V8 to 7.6.303.29. #28955
    * Improves the performance of various APIs such as `JSON.parse` and
      methods called on frozen arrays.
    * Adds the Promise.allSettled method.
    * Improves support of `BigInt` in `Intl` methods.
    * For more information: https://v8.dev/blog/v8-release-76
  * Updated libuv to 1.31.0. #29070
    * `UV_FS_O_FILEMAP` has been added for faster access to memory
      mapped files on Windows.
    * `uv_fs_mkdir()` now returns `UV_EINVAL` for invalid filenames on
      Windows. It previously returned `UV_ENOENT`.
    * The `uv_fs_statfs()` API has been added.
    * The `uv_os_environ()` and `uv_os_free_environ()` APIs have been
      added.
* fs:
  * Added `fs.writev`, `fs.writevSync` and `filehandle.writev` (promise
    version) methods. They allow to write an array of `ArrayBufferView`s
    to a file descriptor. #25925
    #29186
* http:
  * Added three properties to `OutgoingMessage.prototype`:
    `writableObjectMode`, `writableLength` and `writableHighWaterMark`
    #29018
* stream:
  * Added an new property `readableEnded` to readable streams. Its value
    is set to `true` when the `'end'` event is emitted.
    #28814
  * Added an new property `writableEnded` to writable streams. Its value
    is set to `true` after `writable.end()` has been called.
    #28934

PR-URL: #29210


      2019-08-20, Version 12.9.0 (Current)

Notable changes:

* crypto:
  * Added an oaepHash option to asymmetric encryption which allows
    users to specify a hash function when using OAEP padding.
    #28335
* deps:
  * Updated V8 to 7.6.303.29. #28955
    * Improves the performance of various APIs such as `JSON.parse` and
      methods called on frozen arrays.
    * Adds the Promise.allSettled method.
    * Improves support of `BigInt` in `Intl` methods.
    * For more information: https://v8.dev/blog/v8-release-76
  * Updated libuv to 1.31.0. #29070
    * `UV_FS_O_FILEMAP` has been added for faster access to memory
      mapped files on Windows.
    * `uv_fs_mkdir()` now returns `UV_EINVAL` for invalid filenames on
      Windows. It previously returned `UV_ENOENT`.
    * The `uv_fs_statfs()` API has been added.
    * The `uv_os_environ()` and `uv_os_free_environ()` APIs have been
      added.
* fs:
  * Added `fs.writev`, `fs.writevSync` and `filehandle.writev` (promise
    version) methods. They allow to write an array of `ArrayBufferView`s
    to a file descriptor. #25925
    #29186
* http:
  * Added three properties to `OutgoingMessage.prototype`:
    `writableObjectMode`, `writableLength` and `writableHighWaterMark`
    #29018
* stream:
  * Added an new property `readableEnded` to readable streams. Its value
    is set to `true` when the `'end'` event is emitted.
    #28814
  * Added an new property `writableEnded` to writable streams. Its value
    is set to `true` after `writable.end()` has been called.
    #28934

PR-URL: #29210


      2019-08-20, Version 12.9.0 (Current)

Notable changes:

* crypto:
  * Added an oaepHash option to asymmetric encryption which allows
    users to specify a hash function when using OAEP padding.
    nodejs#28335
* deps:
  * Updated V8 to 7.6.303.29. nodejs#28955
    * Improves the performance of various APIs such as `JSON.parse` and
      methods called on frozen arrays.
    * Adds the Promise.allSettled method.
    * Improves support of `BigInt` in `Intl` methods.
    * For more information: https://v8.dev/blog/v8-release-76
  * Updated libuv to 1.31.0. nodejs#29070
    * `UV_FS_O_FILEMAP` has been added for faster access to memory
      mapped files on Windows.
    * `uv_fs_mkdir()` now returns `UV_EINVAL` for invalid filenames on
      Windows. It previously returned `UV_ENOENT`.
    * The `uv_fs_statfs()` API has been added.
    * The `uv_os_environ()` and `uv_os_free_environ()` APIs have been
      added.
* fs:
  * Added `fs.writev`, `fs.writevSync` and `filehandle.writev` (promise
    version) methods. They allow to write an array of `ArrayBufferView`s
    to a file descriptor. nodejs#25925
    nodejs#29186
* http:
  * Added three properties to `OutgoingMessage.prototype`:
    `writableObjectMode`, `writableLength` and `writableHighWaterMark`
    nodejs#29018
* stream:
  * Added an new property `readableEnded` to readable streams. Its value
    is set to `true` when the `'end'` event is emitted.
    nodejs#28814
  * Added an new property `writableEnded` to writable streams. Its value
    is set to `true` after `writable.end()` has been called.
    nodejs#28934

PR-URL: nodejs#29210


      crypto: extend RSA-OAEP support with oaepHash

This adds an oaepHash option to asymmetric encryption which allows
users to specify a hash function when using OAEP padding. This
feature is required for interoperability with WebCrypto applications.

PR-URL: nodejs#28335
Fixes: nodejs#25756
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>


      test: add test for OAEP hash mismatch

PR-URL: nodejs#28335
Fixes: nodejs#25756
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>


      2019-08-20, Version 12.9.0 (Current)

Notable changes:

* crypto:
  * Added an oaepHash option to asymmetric encryption which allows
    users to specify a hash function when using OAEP padding.
    nodejs#28335
* deps:
  * Updated V8 to 7.6.303.29. nodejs#28955
    * Improves the performance of various APIs such as `JSON.parse` and
      methods called on frozen arrays.
    * Adds the Promise.allSettled method.
    * Improves support of `BigInt` in `Intl` methods.
    * For more information: https://v8.dev/blog/v8-release-76
  * Updated libuv to 1.31.0. nodejs#29070
    * `UV_FS_O_FILEMAP` has been added for faster access to memory
      mapped files on Windows.
    * `uv_fs_mkdir()` now returns `UV_EINVAL` for invalid filenames on
      Windows. It previously returned `UV_ENOENT`.
    * The `uv_fs_statfs()` API has been added.
    * The `uv_os_environ()` and `uv_os_free_environ()` APIs have been
      added.
* fs:
  * Added `fs.writev`, `fs.writevSync` and `filehandle.writev` (promise
    version) methods. They allow to write an array of `ArrayBufferView`s
    to a file descriptor. nodejs#25925
    nodejs#29186
* http:
  * Added three properties to `OutgoingMessage.prototype`:
    `writableObjectMode`, `writableLength` and `writableHighWaterMark`
    nodejs#29018
* stream:
  * Added an new property `readableEnded` to readable streams. Its value
    is set to `true` when the `'end'` event is emitted.
    nodejs#28814
  * Added an new property `writableEnded` to writable streams. Its value
    is set to `true` after `writable.end()` has been called.
    nodejs#28934

PR-URL: nodejs#29210


      crypto: extend RSA-OAEP support with oaepHash

This adds an oaepHash option to asymmetric encryption which allows
users to specify a hash function when using OAEP padding. This
feature is required for interoperability with WebCrypto applications.

PR-URL: nodejs#28335
Fixes: nodejs#25756
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>


      test: add test for OAEP hash mismatch

PR-URL: nodejs#28335
Fixes: nodejs#25756
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>


      2019-08-20, Version 12.9.0 (Current)

Notable changes:

* crypto:
  * Added an oaepHash option to asymmetric encryption which allows
    users to specify a hash function when using OAEP padding.
    nodejs#28335
* deps:
  * Updated V8 to 7.6.303.29. nodejs#28955
    * Improves the performance of various APIs such as `JSON.parse` and
      methods called on frozen arrays.
    * Adds the Promise.allSettled method.
    * Improves support of `BigInt` in `Intl` methods.
    * For more information: https://v8.dev/blog/v8-release-76
  * Updated libuv to 1.31.0. nodejs#29070
    * `UV_FS_O_FILEMAP` has been added for faster access to memory
      mapped files on Windows.
    * `uv_fs_mkdir()` now returns `UV_EINVAL` for invalid filenames on
      Windows. It previously returned `UV_ENOENT`.
    * The `uv_fs_statfs()` API has been added.
    * The `uv_os_environ()` and `uv_os_free_environ()` APIs have been
      added.
* fs:
  * Added `fs.writev`, `fs.writevSync` and `filehandle.writev` (promise
    version) methods. They allow to write an array of `ArrayBufferView`s
    to a file descriptor. nodejs#25925
    nodejs#29186
* http:
  * Added three properties to `OutgoingMessage.prototype`:
    `writableObjectMode`, `writableLength` and `writableHighWaterMark`
    nodejs#29018
* stream:
  * Added an new property `readableEnded` to readable streams. Its value
    is set to `true` when the `'end'` event is emitted.
    nodejs#28814
  * Added an new property `writableEnded` to writable streams. Its value
    is set to `true` after `writable.end()` has been called.
    nodejs#28934

PR-URL: nodejs#29210

crypto: extend RSA-OAEP support with oaepHash
This adds an oaepHash option to asymmetric encryption which allows users to specify a hash function when using OAEP padding. This feature is required for interoperability with WebCrypto applications.

Loading status checks…

9c1a148

nodejs-github-bot added C++ lib / src labels Jun 21, 2019

tniessen added crypto and removed lib / src labels Jun 21, 2019

fixup! crypto: extend RSA-OAEP support with oaepHash

Loading status checks…

0caa1e5

tniessen added the semver-minor label Jun 24, 2019

panva referenced this pull request Jul 6, 2019

RSA-OAEP-256 #29

Closed

tniessen closed this Aug 7, 2019

bnoordhuis referenced this pull request Aug 15, 2019

Decrypting SubtleCrypto.wrapkey() key received from browser #2109

Open

targos added a commit that referenced this pull request Aug 19, 2019

targos referenced this pull request Aug 19, 2019

v12.9.0 release proposal #29210

Merged

targos added a commit that referenced this pull request Aug 19, 2019

targos added a commit that referenced this pull request Aug 20, 2019

targos added a commit to targos/node that referenced this pull request Aug 20, 2019

targos added a commit that referenced this pull request Aug 20, 2019

ronag added a commit to nxtedition/node that referenced this pull request Aug 23, 2019

codebytere referenced this pull request Aug 26, 2019

crypto: don't expose OpenSSL internals #29325

Closed

4 of 4 tasks complete

seebees referenced this pull request Aug 27, 2019

Use oaepHash to support additional padding options. #198

Open

JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019

test: add test for OAEP hash mismatch
PR-URL: nodejs#28335 Fixes: nodejs#25756 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

52d3e2a

JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019

test: add test for OAEP hash mismatch
PR-URL: nodejs#28335 Fixes: nodejs#25756 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

c251345

JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019

nodejs/node

crypto: extend RSA-OAEP support with oaepHash #28335

crypto: extend RSA-OAEP support with oaepHash #28335

tniessen commented Jun 21, 2019

nodejs-github-bot added C++ lib / src labels Jun 21, 2019

tniessen added crypto and removed lib / src labels Jun 21, 2019

This comment has been minimized.

panva commented Jun 21, 2019 •

edited

This comment has been minimized.

tniessen commented Jun 23, 2019

tniessen added the semver-minor label Jun 24, 2019

This comment has been minimized.

sam-github commented Jun 24, 2019

This comment has been minimized.

panva commented Jun 24, 2019

This comment has been minimized.

panva commented Jun 24, 2019

This comment has been minimized.

tniessen commented Jun 24, 2019

This comment has been minimized.

panva commented Jun 24, 2019

This comment has been minimized.

sam-github commented Jun 24, 2019

This comment has been minimized.

tniessen commented Jul 12, 2019

This comment has been minimized.

panva commented Jul 12, 2019

This comment has been minimized.

tniessen commented Jul 18, 2019

This comment has been minimized.

panva commented Jul 19, 2019

This comment has been minimized.

sam-github commented Jul 22, 2019

tniessen closed this Aug 7, 2019

nodejs/node

Join GitHub today

crypto: extend RSA-OAEP support with oaepHash #28335

Conversation

tniessen commented Jun 21, 2019

Checklist

nodejs-github-bot added C++ lib / src labels Jun 21, 2019

tniessen added crypto and removed lib / src labels Jun 21, 2019

This comment has been minimized.

panva commented Jun 21, 2019 • edited

This comment has been minimized.

tniessen commented Jun 23, 2019

tniessen added the semver-minor label Jun 24, 2019

This comment has been minimized.

sam-github commented Jun 24, 2019

This comment has been minimized.

panva commented Jun 24, 2019

This comment has been minimized.

panva commented Jun 24, 2019

This comment has been minimized.

tniessen commented Jun 24, 2019

This comment has been minimized.

panva commented Jun 24, 2019

This comment has been minimized.

sam-github commented Jun 24, 2019

This comment has been minimized.

tniessen commented Jul 12, 2019

This comment has been minimized.

panva commented Jul 12, 2019

This comment has been minimized.

tniessen commented Jul 18, 2019

This comment has been minimized.

panva commented Jul 19, 2019

This comment has been minimized.

sam-github commented Jul 22, 2019

tniessen closed this Aug 7, 2019

panva commented Jun 21, 2019 •

edited