Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Roll forward "Run Travis tests in Docker (#1830)" #1838
Merged
Conversation
Do not merge until certbot/certbot#3058 lands. That change broke the certbot tests because it switched to a MariaDB 10.1-specific syntax. certbot/certbot#3058 changes the certbot tests to use Boulder's docker-compose.yml, so they will get MariaDB 10.1 automatically.
|
certbot/certbot#3058 landed |
|
Thanks @bmw! @rolandshoemaker, @ccppuu, could you review this one? |
|
LGTM. |
test/create_db.sh
Outdated
| @@ -42,6 +39,8 @@ for dbenv in $DBENVS; do | |||
| if [[ ${MYSQL_CONTAINER} ]]; then | |||
| sed -e "s/'localhost'/'%'/g" < ${USERS_SQL} | \ | |||
| mysql $dbconn -D $db || die "unable to add users to ${db}" | |||
| elif mysqld -V | grep "10.0"; then | |||
| mysql $dbconn -D $db < test/mariadb100_users.sql | |||
cpu
May 24, 2016
Contributor
@jsha is this needed now that certbot/certbot#3058 is merged? I think mariadb100_users.sql was dropped from the PR and this will break.
|
LGTM as of 5b6280b. |
jsha
added a commit
that referenced
this pull request
May 25, 2016
Commit test/boulder-tools (forgot to include them in #1838). Mount $GOPATH as a volume in the container so that source code changes take effect in the container without a rebuild, and build cache can make repeated runs faster. Install rabbitmq-setup outside of the mounted-over path so it still exists. Remove unnecessary entries from Dockerfile's PATH and GOBIN.
Merged
rolandshoemaker
added a commit
that referenced
this pull request
May 25, 2016
Commit test/boulder-tools (forgot to include them in #1838). Mount $GOPATH as a volume in the container so that source code changes take effect in the container without a rebuild, and build cache can make repeated runs faster. Install rabbitmq-setup outside of the mounted-over path so it still exists. Remove unnecessary entries from Dockerfile's PATH and GOBIN. #1842
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
That change broke the certbot tests because it switched to a MariaDB
10.1-specific syntax. certbot/certbot#3058 changes the certbot tests to use
Boulder's docker-compose.yml, so they will get MariaDB 10.1 automatically.