Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requirements.txt: Use pip conditionals to be ready for Jython3 #13

Closed
wants to merge 1 commit into from

Conversation

@cclauss
Copy link

cclauss commented May 20, 2019

No description provided.

@jeff5
Copy link
Member

jeff5 commented May 22, 2019

This is not a matter of Python 2 vs Python 3. It builds identically AFAIK. (Although RTD uses 2.7: do we know where to set that?)

The motivation for pinning sphinx to <2.0 for now was this RTD defect: readthedocs/sphinx_rtd_theme#739, so as to avoid this ugly warning:

...\jythonbook\venv\lib\site-packages\sphinx_rtd_theme\search.html:20: RemovedInSphinx30Warning: To modify script_files in the theme is deprecated. Please insert a <script> tag directly in your theme instead.
  {{ super() }}

It's fixed, but not released. pip install --upgrade sphinx_rtd_theme still gives me 0.4.3 which contains it. When the fix is released, we could undo the pin unconditionally, I believe.

@cclauss
Copy link
Author

cclauss commented May 22, 2019

Understood. Thanks. Closing...

@cclauss cclauss closed this May 22, 2019
@cclauss cclauss deleted the cclauss:patch-1 branch May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.