Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upNew API Implementation #191
+1,723
−2,027
Conversation
oreoshake
added some commits
Oct 20, 2015
stve
reviewed
Nov 5, 2015
README.md
Outdated
| } | ||
| config.hpkp = { | ||
| :max_age => 60.days.to_i, | ||
| :include_subdomains => true, | ||
| :report_uri => '//example.com/uri-directive', | ||
| :report_uri => "https//example.com/uri-directive", |
This comment has been minimized.
This comment has been minimized.
oreoshake
and others
added some commits
Nov 5, 2015
This comment has been minimized.
This comment has been minimized.
|
This code is now running on |
oreoshake
added a commit
that referenced
this pull request
Dec 11, 2015
oreoshake
merged commit 1918ce2
into
3.x
Dec 11, 2015
oreoshake
deleted the
env-rack-config
branch
Dec 11, 2015
This comment has been minimized.
This comment has been minimized.
|
Just noticed 'X-Permitted-Cross-Domain-Policies' and 'X-Content-Type-Options' are listed twice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
oreoshake commentedNov 5, 2015
Followup to #181. As with the last PR, it's probably better to ignore the diff and look at the code directly.
The biggest change in this PR is the added support for "named overrides" - additional configuration objects that can be referenced by name. The header values are all precomputed so named overrides save the overhead of building a policy per request.
(from the readme