Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove unstable_ prefix from Suspense #13922
Conversation
sebmarkbage
requested review from
sophiebits,
gaearon and
acdlite
Oct 23, 2018
facebook-github-bot
added
the
CLA Signed
label
Oct 23, 2018
acdlite
approved these changes
Oct 23, 2018
This comment has been minimized.
This comment has been minimized.
|
Although I guess #13921 is a counter argument. :) |
This comment has been minimized.
This comment has been minimized.
|
Would be nice to follow up to understand how it landed while breaking that test. |
This comment has been minimized.
This comment has been minimized.
|
Should maxDuration be prefixed? |
This comment has been minimized.
This comment has been minimized.
|
I think it's fine to leave |
sebmarkbage
merged commit d75c69e
into
facebook:master
Oct 23, 2018
1 check was pending
ci/circleci
Your tests are queued behind your running builds
Details
This comment has been minimized.
This comment has been minimized.
sizebot
commented
Oct 23, 2018
Details of bundled changes.Comparing: 04c4f2f...7d66f90 scheduler
Generated by |
This was referenced Oct 24, 2018
This was referenced Nov 1, 2018
This was referenced Dec 1, 2018
jetoneza
added a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
iyegoroff
added a commit
to iyegoroff/react
that referenced
this pull request
Mar 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
sebmarkbage commentedOct 23, 2018
We are using it with lazy and the combination Suspense + lazy seems pretty stable. maxDuration is not but that's only enabled when you're in ConcurrentMode which is still unstable.
Don't forget to fix www.