Run login capture code upon page navigation if there are password fields present in a <form>
Categories
(Toolkit :: Password Manager, enhancement, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox68 | --- | verified |
People
(Reporter: MattN, Assigned: MattN)
References
(Depends on 1 open bug, Blocks 3 open bugs, Regressed 1 open bug)
Details
(Whiteboard: [webcompat] [passwords:capture-UI])
Attachments
(4 files, 2 obsolete files)
Assignee | ||
Updated•8 years ago
|
Comment hidden (obsolete) |
Comment hidden (obsolete) |
Comment hidden (obsolete) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 6•8 years ago
|
||
Assignee | ||
Comment 7•8 years ago
|
||
Assignee | ||
Comment 8•7 years ago
|
||
Comment 9•7 years ago
|
||
Comment 10•7 years ago
|
||
Assignee | ||
Comment 11•7 years ago
|
||
Assignee | ||
Comment 12•7 years ago
|
||
Comment 13•7 years ago
|
||
Assignee | ||
Comment 14•7 years ago
|
||
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 17•7 years ago
|
||
Assignee | ||
Comment 18•7 years ago
|
||
Comment 19•7 years ago
|
||
Comment 20•7 years ago
|
||
Comment 21•7 years ago
|
||
Comment 22•7 years ago
|
||
Comment 23•7 years ago
|
||
Comment 24•7 years ago
|
||
Comment 25•7 years ago
|
||
Comment 26•7 years ago
|
||
Updated•7 years ago
|
Assignee | ||
Comment 27•7 years ago
|
||
Updated•7 years ago
|
Updated•7 years ago
|
Comment 28•7 years ago
|
||
Comment 29•7 years ago
|
||
Assignee | ||
Comment 30•7 years ago
|
||
Updated•7 years ago
|
Comment 31•6 years ago
|
||
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 32•6 years ago
|
||
MozReview-Commit-ID: 32iv1M3hyBU
Assignee | ||
Comment 33•6 years ago
|
||
MozReview-Commit-ID: JkNq8bahbJZ
Depends on D20839
Assignee | ||
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Assignee | ||
Comment 34•6 years ago
|
||
Depends on D20840
Comment 35•6 years ago
|
||
Comment 36•6 years ago
|
||
Backed out 3 changesets (Bug 1287202) for "e10s test-macosx64/debug-mochitest-e10s-5" failures
Backout link: https://hg.mozilla.org/integration/autoland/rev/9aebabe324dab2e881782658bb75e0c5257eb5cf
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=234666347&repo=autoland&lineNumber=31266
00:28:12 INFO - AddTask.js | Entering test test_4
00:28:12 INFO - checkPromptState: Expected: Please enter your master password.
00:28:12 INFO - TEST-PASS | toolkit/components/passwordmgr/test/mochitest/test_master_password.html | Checking expected message
00:28:12 INFO - TEST-PASS | toolkit/components/passwordmgr/test/mochitest/test_master_password.html | Checking title always visible on OS X
00:28:12 INFO - TEST-PASS | toolkit/components/passwordmgr/test/mochitest/test_master_password.html | Checking textbox visibility
00:28:12 INFO - TEST-PASS | toolkit/components/passwordmgr/test/mochitest/test_master_password.html | Checking passbox visibility
00:28:12 INFO - TEST-PASS | toolkit/components/passwordmgr/test/mochitest/test_master_password.html | Checking checkbox visibility
00:28:12 INFO - TEST-PASS | toolkit/components/passwordmgr/test/mochitest/test_master_password.html | Checking checkbox label
00:28:12 INFO - TEST-PASS | toolkit/components/passwordmgr/test/mochitest/test_master_password.html | Checking checkbox checked
00:28:12 INFO - TEST-PASS | toolkit/components/passwordmgr/test/mochitest/test_master_password.html | Checking expected icon CSS class
00:28:12 INFO - TEST-PASS | toolkit/components/passwordmgr/test/mochitest/test_master_password.html | Checking textbox value
00:28:12 INFO - TEST-PASS | toolkit/components/passwordmgr/test/mochitest/test_master_password.html | Checking passbox value
00:28:12 INFO - TEST-PASS | toolkit/components/passwordmgr/test/mochitest/test_master_password.html | checking button0 default
00:28:12 INFO - TEST-PASS | toolkit/components/passwordmgr/test/mochitest/test_master_password.html | checking button1 default
00:28:12 INFO - TEST-PASS | toolkit/components/passwordmgr/test/mochitest/test_master_password.html | checking button2 default
00:28:12 INFO - TEST-PASS | toolkit/components/passwordmgr/test/mochitest/test_master_password.html | Checking focused element
00:28:12 INFO - Buffered messages finished
00:28:12 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/passwordmgr/test/mochitest/test_master_password.html | checking expected empty user - got "user1", expected ""
00:28:12 INFO - SimpleTest.is@https://example.com/tests/SimpleTest/SimpleTest.js:320:16
00:28:12 INFO - test_4@https://example.com/tests/toolkit/components/passwordmgr/test/mochitest/test_master_password.html:198:3
00:28:12 INFO - asyncnextTick/<@https://example.com/tests/SimpleTest/AddTask.js:70:34
00:28:12 INFO - asyncnextTick@https://example.com/tests/SimpleTest/AddTask.js:86:11
00:28:12 INFO - setTimeout handlerSimpleTest_setTimeoutShim@https://example.com/tests/SimpleTest/SimpleTest.js:684:43
00:28:12 INFO - add_task@https://example.com/tests/SimpleTest/AddTask.js:30:7
00:28:12 INFO - @https://example.com/tests/toolkit/components/passwordmgr/test/mochitest/test_master_password.html:54:1
00:28:12 INFO - Not taking screenshot here: see the one that was previously logged
00:28:12 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/passwordmgr/test/mochitest/test_master_password.html | checking expected empty pass - got "pass1", expected ""
00:28:12 INFO - SimpleTest.is@https://example.com/tests/SimpleTest/SimpleTest.js:320:16
00:28:12 INFO - test_4@https://example.com/tests/toolkit/components/passwordmgr/test/mochitest/test_master_password.html:199:3
00:28:12 INFO - asyncnextTick/<@https://example.com/tests/SimpleTest/AddTask.js:70:34
00:28:12 INFO - asyncnextTick@https://example.com/tests/SimpleTest/AddTask.js:86:11
00:28:12 INFO - setTimeout handlerSimpleTest_setTimeoutShim@https://example.com/tests/SimpleTest/SimpleTest.js:684:43
00:28:12 INFO - add_task@https://example.com/tests/SimpleTest/AddTask.js:30:7
00:28:12 INFO - @https://example.com/tests/toolkit/components/passwordmgr/test/mochitest/test_master_password.html:54:1
00:28:12 INFO - TEST-PASS | toolkit/components/passwordmgr/test/mochitest/test_master_password.html | should be logged out
Assignee | ||
Updated•6 years ago
|
Comment 37•6 years ago
|
||
Comment 38•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c293763c1be2
https://hg.mozilla.org/mozilla-central/rev/13c5c3a63939
https://hg.mozilla.org/mozilla-central/rev/7ca1b9b1a8bb
Comment 40•6 years ago
|
||
(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #12)
Here is a test case using history.pushState that works in Safari and kinda
works in Chrome (only when you hit the back button after a successful
login).
I have reproduced the issue in affected Nightly v68.0a1 from 2019-03-15 and I have verified the fix in Nightly v68.0a1 from 2019-04-23. The password manager pop-up now appears. (The "Show password" string is not displayed near the check-box, but I believe this is unrelated to this issue's verification.)
If this is sufficient to verify this bug, then please set this issue as verified in firefox68.
Other test cases can be found in bug 1166947 just by adding a <form> wrapper
around login fields in those tests.
If it is worth going the extra mile, I would like to verify other cases that might be valid. If you consider this productive, please write me the <form> wrapper and point me to the login fields from bug 1166947 that you mentioned before or any other.
Thanks!
Assignee | ||
Comment 41•6 years ago
|
||
I resolved most of the bugs that depend on this one, confirming that the issue was fixed, so I don't think it's worth testing testcases I make, real world site are more important. I do know of a handful that aren't fixed still e.g. iCloud (bug 1289947) and Hulu (bug 1119083) but we have bugs blocking bug 1119035 for different approaches to capture as well.
Description
•