From a38c8acfada9f2335639bcdd0da8303dfb4094e4 Mon Sep 17 00:00:00 2001 From: Thomas Lamprecht Date: Tue, 10 Sep 2024 16:29:31 +0200 Subject: [PATCH] lxc config generation: opinionated style/code clean-up Signed-off-by: Thomas Lamprecht --- src/PVE/LXC.pm | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index cb24f2d..2fd183a 100644 --- a/src/PVE/LXC.pm +++ b/src/PVE/LXC.pm @@ -651,12 +651,10 @@ sub update_lxc_config { my $major = PVE::Tools::dev_t_major($rdev); my $minor = PVE::Tools::dev_t_minor($rdev); my $device_type_char = S_ISBLK($mode) ? 'b' : 'c'; - my $allow_perms = "r" . $device->{'deny-write'} ? "" : "w"; - $raw .= "lxc.cgroup2.devices.allow = $device_type_char $major:$minor $allow_perms\n"; + my $allow_perms = $device->{'deny-write'} ? 'r' : 'rw'; - if ($device->{'deny-write'}) { - $raw .= "lxc.cgroup2.devices.deny = $device_type_char $major:$minor w\n"; - } + $raw .= "lxc.cgroup2.devices.allow = $device_type_char $major:$minor $allow_perms\n"; + $raw .= "lxc.cgroup2.devices.deny = $device_type_char $major:$minor w\n" if $device->{'deny-write'}; }); # WARNING: DO NOT REMOVE this without making sure that loop device nodes -- 2.39.5