From 56f09314cb4b36b7ec8f16929eb9d7f4dbf48832 Mon Sep 17 00:00:00 2001 From: Fiona Ebner Date: Tue, 28 Feb 2023 11:54:07 +0100 Subject: [PATCH] abstract config: add method to calculate derived properties from a config HA manager currently needs to know about internal details about the configs and how the properties are calculated. With this method, those details are abstracted away, allowing to change the configuration structure. In particular, QemuConfig's 'memory' can be turned into a property string without HA manager needing to know about it (once HA manager switched to using this mehtod). Signed-off-by: Fiona Ebner --- src/PVE/AbstractConfig.pm | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/PVE/AbstractConfig.pm b/src/PVE/AbstractConfig.pm index fcc9738..a286b13 100644 --- a/src/PVE/AbstractConfig.pm +++ b/src/PVE/AbstractConfig.pm @@ -1165,6 +1165,15 @@ sub snapshot_rollback { $class->lock_config($vmid, $updatefn); } +# Calculate a derived property from a configuration. Derived properties are: +# max-cpu - maximum amount of CPUs the guest can currently use (can be a fraction) +# max-memory - maximum amount of memory the guest can currently use +sub get_derived_property { + my ($class, $conf, $name) = @_; + + die "implement me - abstract method\n"; +} + # bash completion helper sub snapshot_list { -- 2.39.5