]> git.proxmox.com Git - pve-network.git/commitdiff
sdn: dhcp: only consider subnets that have dhcp-range configured
authorStefan Hanreich <s.hanreich@proxmox.com>
Fri, 5 Apr 2024 13:17:56 +0000 (15:17 +0200)
committerThomas Lamprecht <t.lamprecht@proxmox.com>
Mon, 8 Apr 2024 15:57:18 +0000 (17:57 +0200)
If DHCP is enabled on a zone with subnets, but no subnet has a
dhcp-range configured, then starting a VM will fail because no IP can
be allocated. This patch fixes this by only considering subnets that
have a dhcp-range configured and only failing if there is at least one
subnet with a dhcp-range configured.

Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
Reviewed-by: Stefan Lendl <s.lendl@proxmox.com>
Tested-by: Stefan Lendl <s.lendl@proxmox.com>
Signed-off-by: Stefan Lendl <s.lendl@proxmox.com>
src/PVE/Network/SDN/Vnets.pm

index 4542b70a658620e318b6ba0663909a7deeb93650..cbf0a074095999f82c829f1f2eb18bbb9bd17561 100644 (file)
@@ -118,6 +118,7 @@ sub add_next_free_cidr {
            my $network = $subnet->{network};
 
            next if Net::IP::ip_get_version($network) != $ipversion || $ips->{$ipversion};
+           next if !$subnet->{'dhcp-range'};
            $subnetcount++;
 
            eval {