]> git.proxmox.com Git - ovs.git/commitdiff
ovs-monitor-ipsec: Suppress "unknown %d argument" warning.
authorMark Gray <mark.d.gray@redhat.com>
Thu, 24 Dec 2020 10:06:20 +0000 (05:06 -0500)
committerIlya Maximets <i.maximets@ovn.org>
Tue, 5 Jan 2021 18:21:32 +0000 (19:21 +0100)
As 'ovs-vswitchd' does not understand IPsec tunnel options, it
gives a warning message. This can be safely suppressed.

Reported at: https://bugzilla.redhat.com/show_bug.cgi?id=1906701
Signed-off-by: Mark Gray <mark.d.gray@redhat.com>
Acked-by: Eelco Chaudron <echaudro@redhat.com>
Acked-by: Flavio Leitner <fbl@sysclose.org>
Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
lib/netdev-vport.c

index 15567e52445308c920efc417367012ead0c99ad2..499c0291c933f695647b36ef61a8e23f4344d42e 100644 (file)
@@ -767,6 +767,14 @@ set_tunnel_config(struct netdev *dev_, const struct smap *args, char **errp)
                  }
                  tnl_cfg.payload_ethertype = htons(payload_ethertype);
             }
+        } else if (!strcmp(node->key, "remote_cert") ||
+                   !strcmp(node->key, "remote_name") ||
+                   !strcmp(node->key, "psk")) {
+            /* When configuring OVS for IPsec, these keys may be set in the
+               tunnel port's 'options' column. 'ovs-vswitchd' does not directly
+               use them, but they are read by 'ovs-monitor-ipsec'. In order to
+               suppress the "unknown %s argument" warning message below, we
+               handle them here by ignoring them. */
         } else {
             ds_put_format(&errors, "%s: unknown %s argument '%s'\n", name,
                           type, node->key);