]> git.proxmox.com Git - mirror_kronosnet.git/commitdiff
[transports] use SO_REUSEADDR only for sctp
authorFabio M. Di Nitto <fdinitto@redhat.com>
Tue, 25 Feb 2020 07:18:53 +0000 (08:18 +0100)
committerFabio M. Di Nitto <fdinitto@redhat.com>
Wed, 26 Feb 2020 05:18:25 +0000 (06:18 +0100)
Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>
libknet/transport_common.c
libknet/transport_sctp.c

index 3219243036dbc55125fa89986fd914a46c057b12..000369743135a8845a12c165e9d614cb9cd48669 100644 (file)
@@ -349,15 +349,6 @@ int _configure_transport_socket(knet_handle_t knet_h, int sock, struct sockaddr_
 #endif
        }
 
-       value = 1;
-       if (setsockopt(sock, SOL_SOCKET, SO_REUSEADDR, &value, sizeof(value)) < 0) {
-               savederrno = errno;
-               err = -1;
-               log_err(knet_h, KNET_SUB_TRANSPORT, "Unable to set %s reuseaddr: %s",
-                       type, strerror(savederrno));
-               goto exit_error;
-       }
-
 exit_error:
        errno = savederrno;
        return err;
index 422a06ff7c61a1b40096be23a6a8a184d35eeaa0..5e818fe37320511a855847edf0b3f0ea83f008f7 100644 (file)
@@ -169,6 +169,15 @@ static int _configure_sctp_socket(knet_handle_t knet_h, int sock, struct sockadd
                goto exit_error;
        }
 
+       value = 1;
+       if (setsockopt(sock, SOL_SOCKET, SO_REUSEADDR, &value, sizeof(value)) < 0) {
+               savederrno = errno;
+               err = -1;
+               log_err(knet_h, KNET_SUB_TRANSPORT, "Unable to set reuseaddr on socket %d: %s",
+                       sock, strerror(savederrno));
+               goto exit_error;
+       }
+
        value = 1;
        if (setsockopt(sock, level, SCTP_NODELAY, &value, sizeof(value)) < 0) {
                savederrno = errno;