]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
ALSA: pcm: Test for "silence" field in struct "pcm_format_data"
authorFabio M. De Francesco <fmdefrancesco@gmail.com>
Sat, 9 Apr 2022 01:26:55 +0000 (03:26 +0200)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 20 May 2022 12:42:35 +0000 (14:42 +0200)
commit9ce8694d429a973d13729998c8a8973a8c08ae00
tree869f2685def71777698b1ea06a8a71448f819daf
parentde07922174d52ee337d99c88d4aed14b1dde74fe
ALSA: pcm: Test for "silence" field in struct "pcm_format_data"

BugLink: https://bugs.launchpad.net/bugs/1969857
commit 2f7a26abb8241a0208c68d22815aa247c5ddacab upstream.

Syzbot reports "KASAN: null-ptr-deref Write in
snd_pcm_format_set_silence".[1]

It is due to missing validation of the "silence" field of struct
"pcm_format_data" in "pcm_formats" array.

Add a test for valid "pat" and, if it is not so, return -EINVAL.

[1] https://lore.kernel.org/lkml/000000000000d188ef05dc2c7279@google.com/

Reported-and-tested-by: syzbot+205eb15961852c2c5974@syzkaller.appspotmail.com
Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20220409012655.9399-1-fmdefrancesco@gmail.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
sound/core/pcm_misc.c