]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
serial: samsung_tty: do not unlock port->lock for uart_write_wakeup()
authorJiri Slaby <jslaby@suse.cz>
Tue, 8 Mar 2022 11:51:53 +0000 (12:51 +0100)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 20 May 2022 13:19:52 +0000 (15:19 +0200)
commit443cd85db474cf8acb6cf43f7ff18e90ed4c497a
tree76b4edb9dbf02a6848da97c9aca68254a6571c70
parent4ea1d5c57870732c717d71136c9c8bfd488dcdde
serial: samsung_tty: do not unlock port->lock for uart_write_wakeup()

BugLink: https://bugs.launchpad.net/bugs/1971497
[ Upstream commit 988c7c00691008ea1daaa1235680a0da49dab4e8 ]

The commit c15c3747ee32 (serial: samsung: fix potential soft lockup
during uart write) added an unlock of port->lock before
uart_write_wakeup() and a lock after it. It was always problematic to
write data from tty_ldisc_ops::write_wakeup and it was even documented
that way. We fixed the line disciplines to conform to this recently.
So if there is still a missed one, we should fix them instead of this
workaround.

On the top of that, s3c24xx_serial_tx_dma_complete() in this driver
still holds the port->lock while calling uart_write_wakeup().

So revert the wrap added by the commit above.

Cc: Thomas Abraham <thomas.abraham@linaro.org>
Cc: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Hyeonkook Kim <hk619.kim@samsung.com>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Link: https://lore.kernel.org/r/20220308115153.4225-1-jslaby@suse.cz
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/tty/serial/samsung.c