tree 16f841305a007119cf997321e2896e7b1e5c76d3
parent ef408dae0473b5058f79b329328c0650396c97ee
author Svet Ganov <svetoslavganov@google.com> 1569560720 -0700
committer android-build-team Robot <android-build-team-robot@google.com> 1570761320 +0000

Update PermissionChecker usages to avoid unnecessary attribution.

We had accidental usages of the PermissionChecker for cases where no
private data was provided to the app but the checkPermission API on
the latter also did blame data access on the app. The PermissionChecker
was designed to handle IPC calls and not for generic API checks.

To avoid future accidental incorrect PermissionChecker usages this
change renames the existing APIs of the latter to clearly indicate
that they should be used for data delivery and also adds sibling
methods for doing the same permission checks for preflight purposes.
Also the documentation is improved to furhter assist developers.

In addition, this change fixes accidental permission checker usages
that blame when they should not by using the new preflight flavor
of the permission check APIs.

Test:
    atest com.android.settingslib.location.RecentLocationAppsTest
    atest CtsPermissionTestCases
    added: LocationAccessCheckTest#notificationOnlyForAccessesSinceFeatureWasEnabled
    added: LocationAccessCheckTest#noNotificationIfFeatureDisabled
    added: LocationAccessCheckTest#noNotificationIfBlamerNotSystemOrLocationProvider
    added: LocationAccessCheckTest#testOpeningLocationSettingsDoesNotTriggerAccess

bug:141028068
Merged-In: I902a0ab049783a222ac2acdfac93ecd49f34dece
Change-Id: I902a0ab049783a222ac2acdfac93ecd49f34dece
(cherry picked from commit 625b69e00869d041b3114346965cd72a5d5c3c6a)