commit 6a68abbd096b5e4aef8078a10e6b5f1cad7d3578
author Joen Chen <joenchen@google.com> Fri Jan 12 02:23:05 2024 +0000
committer Joen Chen <joenchen@google.com> Mon Jan 15 22:43:29 2024 +0000
tree 0a7583e6d68cd8db8b36c9d29edd16bc6c2de7c7
parent 66c0364e1b636b29cd5168ec7723c0a2ac820ca7

libhwc2.1: restrict the external display to a single DPP configuration

There is flickring issue when the external display has mixed composition
type. To avoid it, HWC restricts the external display to a single DDP
configuration to have the same composition type.

Bug: 311578920
Test: check the mini player case
Change-Id: If0b0d834b0a3568df50dbebf1762fdb2103f773c

libhwc2.1/libresource/ExynosResourceManagerModule.cpp

diff --git a/libhwc2.1/libresource/ExynosResourceManagerModule.cpp b/libhwc2.1/libresource/ExynosResourceManagerModule.cpp
index 255ea66..0428350 100644
--- a/libhwc2.1/libresource/ExynosResourceManagerModule.cpp
+++ b/libhwc2.1/libresource/ExynosResourceManagerModule.cpp
@@ -577,3 +577,15 @@
 
     return 0;
 }
+
+bool ExynosResourceManagerModule::isAssignable(ExynosMPP* candidateMPP, ExynosDisplay* display,
+                                               struct exynos_image& src, struct exynos_image& dst,
+                                               ExynosMPPSource* mppSrc) {
+    if (display != nullptr && candidateMPP != nullptr &&
+        display->mType == HWC_DISPLAY_EXTERNAL &&
+        !(candidateMPP->mPhysicalType == MPP_DPP_VGRFS && candidateMPP->mPhysicalIndex == 0)) {
+        return false;
+    }
+    return gs201::ExynosResourceManagerModule::isAssignable(candidateMPP, display, src, dst,
+                                                            mppSrc);
+}

libhwc2.1/libresource/ExynosResourceManagerModule.h

diff --git a/libhwc2.1/libresource/ExynosResourceManagerModule.h b/libhwc2.1/libresource/ExynosResourceManagerModule.h
index c4258c9..e9ab5ad 100644
--- a/libhwc2.1/libresource/ExynosResourceManagerModule.h
+++ b/libhwc2.1/libresource/ExynosResourceManagerModule.h
@@ -48,6 +48,9 @@
                              const DPUblockId_t& blkId, const AXIPortId_t& axiId,
                              ExynosDisplay* mainDisp, ExynosDisplay* minorDisp,
                              const ConstraintRev_t& constraintsRev);
+        virtual bool isAssignable(ExynosMPP* candidateMPP, ExynosDisplay* display,
+                                  struct exynos_image& src, struct exynos_image& dst,
+                                  ExynosMPPSource* mppSrc);
 
     private:
         ConstraintRev_t mConstraintRev;