tree 33593f1153258e13675a934902b7f9f87d78e008
parent 2ab8245a3be08a29d2fc6cc77233e09d89096f0d
author Yigit Boyar <yboyar@google.com> 1610693622 -0800
committer Yigit Boyar <yboyar@google.com> 1610751808 -0800

Preserve type in query result adapters

This CL fixes a bug that happens only in KSP pipeline.

When a dao method returns List<T> where T maps to a primitive in java
(e.g. List<Long>) and non null, Room would end up using a primitive
column row adapter for T. ListQueryResultAdapter previously read its
type argument from the row adapter, which is a problem because the row
adapter has primitive type.

I've updated ListQueryResultAdapter to explicitly receive the type on
construction instead of relying on the row adapter. Same case for
ImmutableList.

Both Java and Guava optional hits a similar issue as well. In both
cases, I changed the row adapter query to also use a nullable type when
querying to ensure that we'll prefer a row adapter that can return null
values. Otherwise, in a case like Optional<Int>, we would return
Optional.of(0) because we would look for a non-null row adapter even
though Optional semantically accepts nullable.

I've also added more tests for Binders. They were not failing without
the change but I decided to keep them.

Unfortunately, some of these tests fail with KAPT until b/146755796 is
fixed. To be able to disable them for kapt, I've added a BuildConfig
field to pass down whether ksp was used during compilation.

Fixes: 177515673
Bug: 146755796
Test: BoxedNonNullTypesTest
Change-Id: I7f5331f6b5b5566bdb17c715d76757e1b6436f82