tree cb0a908b55ac885606aca40924ec24d496ad9f16
parent 78c11a784bc6f65e43bc545dc81e8c666e1b5b6d
author Yigit Boyar <yboyar@google.com> 1599779159 -0700
committer Yigit Boyar <yboyar@google.com> 1599789941 -0700

Reduce XElement API surface

XElement had a bunch of methods/fields that we carried over from
java implementation that does not make sense in KSP. For instance,
method parameters in KSP do not extend from declaration.

Moreover, having methods like isPublic does not always make sense
for certain elements like method parameters.

I've moved modifier related methods to XHasModifiers.
I've removed  from element as it does not make sense for
constructor functions.
I've separated XVariableElement into two, XMethodParameterElement
and XFieldElement to be more clear about distinctions (they were
already implemented separately in Javac).
I've removed packageName from XElement and moved it into XTypeElement
which is the only place we ever use it.

In current design, XElement is almost like a KSAnnotated.
Even though kotlin method parameters wont be elements, i kept the
element in the name to still have the resemblance.

Bug: 160323720
Test: existing tests
Change-Id: I0539ffc1f2894419cf31376c79ac6ba49ee6f715