Google Git
Sign in
android / platform / frameworks / support / 9b41215856f647b9deec4526a9b285b47d15933e
commit9b41215856f647b9deec4526a9b285b47d15933e[log] [tgz]
authorDaniel Santiago Rivera <danysantiago@google.com>Fri Sep 23 22:26:42 2022 -0400
committerDaniel Santiago Rivera <danysantiago@google.com>Tue Sep 27 09:18:44 2022 -0400
treeaf5f1f02c31d55830d9588da89265179b10320b5
parent2dff6f848f676ec173a1bbc70b29d27fdf0224c6 [diff]
Start generating Kotlin for FieldReadWriteWriter.readFromCursor()

To enable partial migration to XPoet this CL makes it so that the Pojo cursor reading code is generated in a separate Kotlin class that is then called from the Java Dao impl. This partial migration moves PrimitiveColumnTypeAdapter to XPoet, other type adapters will follow.

Additionally, this CL moves various JavaPoet TypeName usages in Room's value objects to XTypeName, mainly Pojo.typeName, most of the move is a refactor using toJavaPoet() that is a temporary compatibility API to be removed.

Due to the amount of type converters used in the integration test app this change only validates that the Java runtime behaves as expected and that the Kotlin generated code compiles (via KotlinCodeGenTest) but does not validate the runtime behaviour of the Kotlin codegen. We need to have all type converters and cursor readers migrated to run the integration tests.

As more of Room is migrated more XPoet APIs are added, in this CL we now have:
* begin, next and end control flow
* code block of a new instance, using the 'new' keyword in Java, but not in Kotlin
* code block of an unsafe cast, using the parenthesis syntax in Java and the 'as' keyword in Kotlin
* addLocalVariable is fixed (now that is being used)

Test: Existing tests + KotlinCodeGenTest
Change-Id: Id25a6e874fe9a03768ceca7e2c2a606ac2f469a2
55 files changed
tree: af5f1f02c31d55830d9588da89265179b10320b5
  1. .github/
  2. .idea/
  3. activity/
  4. ads/
  5. annotation/
  6. appcompat/
  7. appsearch/
  8. arch/
  9. asynclayoutinflater/
  10. autofill/
  11. benchmark/
  12. biometric/
  13. bluetooth/
  14. browser/
  15. buildSrc/
  16. buildSrc-tests/
  17. busytown/
  18. camera/
  19. car/
  20. cardview/
  21. collection/
  22. compose/
  23. concurrent/
  24. constraintlayout/
  25. contentpager/
  26. coordinatorlayout/
  27. core/
  28. credentials/
  29. cursoradapter/
  30. customview/
  31. datastore/
  32. development/
  33. docs/
  34. docs-public/
  35. docs-tip-of-tree/
  36. documentfile/
  37. draganddrop/
  38. drawerlayout/
  39. dynamicanimation/
  40. emoji/
  41. emoji2/
  42. enterprise/
  43. exifinterface/
  44. external/
  45. fakeannotations/
  46. fragment/
  47. frameworks/
  48. glance/
  49. gradle/
  50. graphics/
  51. gridlayout/
  52. health/
  53. heifwriter/
  54. hilt/
  55. inspection/
  56. interpolator/
  57. javascriptengine/
  58. leanback/
  59. lifecycle/
  60. lint-checks/
  61. loader/
  62. media/
  63. media2/
  64. mediarouter/
  65. metrics/
  66. navigation/
  67. paging/
  68. palette/
  69. percentlayout/
  70. placeholder-tests/
  71. playground-common/
  72. preference/
  73. print/
  74. privacysandbox/
  75. profileinstaller/
  76. recommendation/
  77. recyclerview/
  78. remotecallback/
  79. resourceinspection/
  80. room/
  81. samples/
  82. savedstate/
  83. security/
  84. sharetarget/
  85. slice/
  86. slidingpanelayout/
  87. sqlite/
  88. startup/
  89. swiperefreshlayout/
  90. test/
  91. testutils/
  92. text/
  93. tracing/
  94. transition/
  95. tv/
  96. tvprovider/
  97. vectordrawable/
  98. versionedparcelable/
  99. viewpager/
  100. viewpager2/
  101. wear/
  102. webkit/
  103. window/
  104. work/
  105. .gitignore
  106. .mailmap
  107. build.gradle
  108. cleanBuild.sh
  109. code-review.md
  110. CONTRIBUTING.md
  111. gradle.properties
  112. gradlew
  113. include-composite-deps.gradle
  114. libraryversions.toml
  115. LICENSE.txt
  116. OWNERS
  117. PREUPLOAD.cfg
  118. README.md
  119. settings.gradle
  120. studiow
  121. TEXT_OWNERS
README.md

Android Jetpack

Revved up by Gradle Enterprise

Jetpack is a suite of libraries, tools, and guidance to help developers write high-quality apps easier. These components help you follow best practices, free you from writing boilerplate code, and simplify complex tasks, so you can focus on the code you care about.

Jetpack comprises the androidx.* package libraries, unbundled from the platform APIs. This means that it offers backward compatibility and is updated more frequently than the Android platform, making sure you always have access to the latest and greatest versions of the Jetpack components.

Our official AARs and JARs binaries are distributed through Google Maven.

You can learn more about using it from Android Jetpack landing page.

Contribution Guide

For contributions via GitHub, see the GitHub Contribution Guide.

Note: The contributions workflow via GitHub is currently experimental - only contributions to the following projects are being accepted at this time:

Code Review Etiquette

When contributing to Jetpack, follow the code review etiquette.

Accepted Types of Contributions

  • Bug fixes - needs a corresponding bug report in the Android Issue Tracker
  • Each bug fix is expected to come with tests
  • Fixing spelling errors
  • Updating documentation
  • Adding new tests to the area that is not currently covered by tests
  • New features to existing libraries if the feature request bug has been approved by an AndroidX team member.

We are not currently accepting new modules.

Checking Out the Code

Head over to the onboarding docs to learn more about getting set up and the development workflow!

Continuous integration

Our continuous integration system builds all in progress (and potentially unstable) libraries as new changes are merged. You can manually download these AARs and JARs for your experimentation.

Password and Contributor Agreement before making a change

Before uploading your first contribution, you will need setup a password and agree to the contribution agreement:

Generate a HTTPS password: https://android-review.googlesource.com/new-password

Agree to the Google Contributor Licenses Agreement: https://android-review.googlesource.com/settings/new-agreement

Getting reviewed

  • After you run repo upload, open r.android.com
  • Sign in into your account (or create one if you do not have one yet)
  • Add an appropriate reviewer (use git log to find who did most modifications on the file you are fixing or check the OWNERS file in the project's directory)

Handling binary dependencies

AndroidX uses git to store all the binary Gradle dependencies. They are stored in prebuilts/androidx/internal and prebuilts/androidx/external directories in your checkout. All the dependencies in these directories are also available from google(), jcenter(), or mavenCentral(). We store copies of these dependencies to have hermetic builds. You can pull in a new dependency using our importMaven tool.