| commit | 2905a68e4f6f4104ca42cf56721d6657274c07a3 | [log] [tgz] |
|---|---|---|
| author | Brad Corso <bcorso@google.com> | Wed May 10 13:47:05 2023 -0700 |
| committer | Brad Corso <bcorso@google.com> | Sun May 14 20:04:23 2023 -0700 |
| tree | d9999469b09e38221c0057e9d744127801e0a29b | |
| parent | fa4ce4af842ee12c85b451b2e1d297e10d1a8c32 [diff] |
Fix KSTypeVarianceResolver for type aliases with type parameters. This CL fixes resolution for type aliases with type parameters, e.g. ``` typealias MyAlias<T> = Foo<@JvmSuppressWildcards T, Bar<Baz<T>> ``` This required fixing two main issues. The first issue was that we were incorrectly resolving type aliases with type arguments. In particular, we were replacing the type arguments directly, which only works if the type alias and type have a 1-to-1 type parameter to type argument. For example, `MyAlias<Qux>` would be translated to `Foo<Qux>` rather than `Foo<Qux, Bar<Baz<Qux>>>`. Now, we properly replace the type parameters with its corresponding type argument. The second issue was that we would immediately resolve type aliases when creating a `KspType`, so the information of the type alias definition was not avialable when resolving the type via `KSTypeVarianceResolver`. This meant that we would lose information such as the `@JvmSuppressWildcards` in the type the example above since the type arguments had already been replaced. Now, we keep track of the original type alias in the `KspType` so that we can pass it in when calling `KSTypeVarianceResolver`. In addition, I restructured the `copy*` methods so that we can easily copy a `KspType` without having to duplicate a method in every subtype. Test: KspTypeNamesGoldenTest.kt Change-Id: Iaa300bc140ac3d83db692d7c983cbb8ab3ef28d3
Jetpack is a suite of libraries, tools, and guidance to help developers write high-quality apps easier. These components help you follow best practices, free you from writing boilerplate code, and simplify complex tasks, so you can focus on the code you care about.
Jetpack comprises the androidx.* package libraries, unbundled from the platform APIs. This means that it offers backward compatibility and is updated more frequently than the Android platform, making sure you always have access to the latest and greatest versions of the Jetpack components.
Our official AARs and JARs binaries are distributed through Google Maven.
You can learn more about using it from Android Jetpack landing page.
For contributions via GitHub, see the GitHub Contribution Guide.
Note: The contributions workflow via GitHub is currently experimental - only contributions to the following projects are being accepted at this time:
When contributing to Jetpack, follow the code review etiquette.
We are not currently accepting new modules.
Head over to the onboarding docs to learn more about getting set up and the development workflow!
Our continuous integration system builds all in progress (and potentially unstable) libraries as new changes are merged. You can manually download these AARs and JARs for your experimentation.
Before uploading your first contribution, you will need setup a password and agree to the contribution agreement:
Generate a HTTPS password: https://android-review.googlesource.com/new-password
Agree to the Google Contributor Licenses Agreement: https://android-review.googlesource.com/settings/new-agreement
AndroidX uses git to store all the binary Gradle dependencies. They are stored in prebuilts/androidx/internal and prebuilts/androidx/external directories in your checkout. All the dependencies in these directories are also available from google(), or mavenCentral(). We store copies of these dependencies to have hermetic builds. You can pull in a new dependency using our importMaven tool.
