Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): correct interface #407

Merged
merged 2 commits into from
Apr 4, 2019
Merged

fix(types): correct interface #407

merged 2 commits into from
Apr 4, 2019

Conversation

merlinnot
Copy link
Contributor

Resolves #406

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 3, 2019
callmehiphop
callmehiphop reviewed Apr 3, 2019
View reviewed changes
src/table.ts Outdated Show resolved Hide resolved
@merlinnot merlinnot mentioned this pull request Apr 4, 2019
Closed
@callmehiphop callmehiphop added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Apr 4, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 4, 2019
@codecov
Copy link

codecov bot commented Apr 4, 2019

Codecov Report

Merging #407 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #407   +/-   ##
=======================================
  Coverage   99.46%   99.46%           
=======================================
  Files           4        4           
  Lines         556      556           
  Branches       76       76           
=======================================
  Hits          553      553           
  Misses          2        2           
  Partials        1        1
Impacted Files Coverage Δ
src/table.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 254f386...277d3e7. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 4, 2019 •
edited
Loading

Codecov Report

Merging #407 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #407   +/-   ##
=======================================
  Coverage   99.46%   99.46%           
=======================================
  Files           4        4           
  Lines         556      556           
  Branches       76       76           
=======================================
  Hits          553      553           
  Misses          2        2           
  Partials        1        1
Impacted Files Coverage Δ
src/table.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 254f386...277d3e7. Read the comment docs.

@callmehiphop callmehiphop merged commit da5ed01 into googleapis:master Apr 4, 2019
@callmehiphop
Copy link
Contributor

@merlinnot thanks for the fix!

@release-please release-please bot mentioned this pull request May 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@callmehiphop callmehiphop callmehiphop approved these changes

Assignees
No one assigned
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@merlinnot @callmehiphop @googlebot @kokoro-team