Preserve new lines in cells with option preserveNewLinesInCells (#91) #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rco#91) \n and \r are converted to \u2028 and \u2029 in order to pass through JSON.stringify, then converted back to \n and \r. Note any original \u2028 and \u2029 are converted to \n and \r.
|
My attempt to fix #91. I preferred to use an option to prevent any side effect with Excel users, but it worked for me with Excel on Windows and OSX. |
knownasilya
requested changes
Apr 25, 2017
README.md
Outdated
| @@ -46,6 +46,7 @@ try { | |||
| - Supports optional custom quotation marks | |||
| - Not create CSV column title by passing hasCSVColumnTitle: false, into params. | |||
| - If field is not exist in object then the field value in CSV will be empty. | |||
| - Preserve new lines in cells. Should be used we \r\n line ending for full compatibility with Excel. | |||
There was a problem hiding this comment.
Typo, "should be used with"
README.md
Outdated
| @@ -67,6 +68,7 @@ try { | |||
| - `unwindPath` - String, creates multiple rows from a single JSON document similar to MongoDB's $unwind | |||
| - `excelStrings` - Boolean, converts string data into normalized Excel style data. | |||
| - `includeEmptyRows` - Boolean, includes empty rows. Defaults to `false`. | |||
| - `preserveNewLinesInCells` - Boolean, preserve \r and \n in cells. Defaults to `false`. | |||
There was a problem hiding this comment.
Cells are Excell specific, let's call this something more generic.
|
I'm not sure if this should even be an option. Maybe it should be on by default. |
|
Thanks for the review. I used the term 'value' instead of 'cell', is it fine for you? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
\n and \r are converted to \u2028 and \u2029 in order to pass through
JSON.stringify, then converted back to \n and \r.
Note any original \u2028 and \u2029 are converted to \n and \r.