ComposeModifierWithoutDefault triggers for @Composable Modifier factory functions

[dandc87]

My codebase has some Modifier helpers that can't be converted to Modifier.Nodes, and want to use the Composable factory guidance but Slack lints (latest 1.3.1) don't make that easy.

Currently I have to write this incantation to suppress (task and in-IDE):

@Composable
// noinspection ComposeModifierWithoutDefault
fun @Suppress("ComposeComposableModifier") Modifier.myModifierFactory(
  @SuppressLint("ComposeModifierWithoutDefault") myParameter: String,
): Modifier { ... }

I also get a crash if there are no parameters (just the receiver):

Stack:
ArrayIndexOutOfBoundsException:Arrays$ArrayList.get(null:-1)
←ModifierWithoutDefaultDetector.visitComposable(ModifierWithoutDefaultDetector.kt:59)
←ComposableFunctionDetector$createUastHandler$1.visitMethod(ComposableFunctionDetector.kt:33)
...

[blipinsk]

🆙 We encountered this problem as well.

[svenjacobs]

I think this relates to #369. Composable Modifier factories are now officially permitted by Google so ComposeModifierWithoutDefault needs to be updated and ComposeComposableModifier removed.

[ZacSweers]

Resolved by #378