Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backoff (sleep) if http 429 code is returned #9673

Closed
baracudda opened this issue Sep 7, 2024 · 4 comments
Closed

Backoff (sleep) if http 429 code is returned #9673

baracudda opened this issue Sep 7, 2024 · 4 comments
Labels
kind/feature Feature requests/implementations status/triage This issue needs to be triaged

Comments

@baracudda
Copy link

Issue Kind

Brand new capability

Description

  • I have a project with 50+ dependencies and github.com is set as the primary source priority. However, poetry starts to encounter 429 responses from github after about 30 GET requests within a second or three. When watching with -vvv, poetry clearly does not wait and instead continues retrying the URL until 5 attempts all result in a 429 and crash out of the install command (or lock). Please respect the 429 response.

Impact

if 429 is not respected, installation or lock operations cannot succeed, ever.

Workarounds

github.com cannot be set as "primary" priority

@baracudda baracudda added kind/feature Feature requests/implementations status/triage This issue needs to be triaged labels Sep 7, 2024
@dimbleby
Copy link
Contributor

dimbleby commented Sep 7, 2024

github.com is set as the primary source priority

What does this mean? Github is not a python package repository.

Please provide the details that the issue template asks for, and a way to reproduce whatever it is you are seeing

@baracudda
Copy link
Author

[[tool.poetry.source]]
name = "github"
url = "https://github.com"
priority = "primary"

@dimbleby
Copy link
Contributor

dimbleby commented Sep 7, 2024

yeah, that just wont work. Again: github is not a python package repository.

Please close

@baracudda
Copy link
Author

as requested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Feature requests/implementations status/triage This issue needs to be triaged
Projects
None yet
Development

No branches or pull requests

2 participants