Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASS subtitles not rendered properly but fine on browsers #1388

Open
1 of 3 tasks
SodaWithoutSparkles opened this issue May 16, 2024 · 6 comments
Open
1 of 3 tasks

ASS subtitles not rendered properly but fine on browsers #1388

SodaWithoutSparkles opened this issue May 16, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@SodaWithoutSparkles
Copy link

SodaWithoutSparkles commented May 16, 2024

Describe the bug

  1. Have a video file that:
    • has ASS subtitles with special styles and fonts
  2. Playback the videp file on jellyfin android and select that subtitle
  3. observe that the subtitles are not working correctly
    • Incorrect font
    • Correct color
    • Black background behind text
    • Simultaneous subtitles became jibbrish mess after displaying "correct-ish" subtitles for 1 frame
  4. Use a browser to view the same video
  5. observe that everything works correctly when the video was remuxed:
    • Font is correct without dark background
    • Simultaneous subtitles are displayed correctly

  • When using web player, video gets transcoded, but without the correct font
  • When client settings > ass support in direct play is disabled, video gets transcoded without the correct font
  • when using VLC as external player, most things are normal but still without correct font
  • When using firefox or chrome, zero issues occur. Font, background and simultaneous subtitles are all fine.
  • System subtitles settings does not affect the outcome
  • subtitle file can be provided upon request

Logs

Attached upon further request

Application version

2.6.1

Where did you install the app from?

Google Play

Device information

Poco X4 GT

Android version

Android 13, MIUI 13.2.5.0

Jellyfin server version

10.9.1

Which video player implementations does this bug apply to?

  • Web player (default)
  • Integrated player (ExoPlayer)
  • External player (VLC, mpv, MX Player)
@SodaWithoutSparkles SodaWithoutSparkles added the bug Something isn't working label May 16, 2024
@SodaWithoutSparkles
Copy link
Author

SodaWithoutSparkles commented May 16, 2024

It turns out that it doesnt matter what the video file is. The same ASS subtitle can be pasted to basically any video file and it would have an issue.

It also does not matter if the video is remuxed or directly played.

Pic1: Chrome (correct) (with subtitles from another file):
Screenshot_2024-05-17-00-25-36-722_com android chrome-edit

Pic2: Chrome (correct simultaneous with font and no background) (See those tiny text at top and bottom) :
Screenshot_2024-05-17-00-29-25-648_com android chrome


Pic3: Jellyfin android, incorrect font and background, and subtitles from another file. Compare it with Pic1:
Screenshot_2024-05-17-00-23-34-332_org jellyfin mobile

Jellyfin android, flash 1 frame with "half correct" subtitles then jibbrish which looks like ASS styling. The "half correct" subtitles were supposed to be simultaneous, but the bottom was missing, font is wrong and background was back. These two should match with Pic2.

Pic4: Screenshot_2024-05-17-00-27-23-059_org jellyfin mobile

Pic5: Screenshot_2024-05-17-00-27-30-200_org jellyfin mobile

@SodaWithoutSparkles SodaWithoutSparkles changed the title ASS subtitles not rendered properly because the lack of remuxing ASS subtitles not rendered properly but fine on browsers May 16, 2024
@vincejv
Copy link

vincejv commented May 25, 2024

Last time i recall JMP doesn't have any control on external players like Android's ExoPlayer when it comes to specific rendering issues like these, integrated means it's embedded in the app and doesnt call an external activity to trigger it, but still it's an external library or dependency which the project cant control

You may want to report the issue here https://github.com/google/ExoPlayer/issues

@vincejv
Copy link

vincejv commented May 25, 2024

Actually the issue is already known in upstream

google/ExoPlayer#8435

@vincejv
Copy link

vincejv commented May 25, 2024

Also dupe of #252

@SodaWithoutSparkles
Copy link
Author

SodaWithoutSparkles commented May 25, 2024

Sorry for the dupe. My search didnt find that issue probably because of different symptoms. I was searching for jibbrish ASS subtitle phenomenon as shown in Pic5.

It could also be related to google/ExoPlayer#10295

@SodaWithoutSparkles
Copy link
Author

SodaWithoutSparkles commented May 25, 2024

It should also be noted that ExoPlayer is deprecated and this bug is probably not going to be fixed (if we dont move to the suggested library):

This project is deprecated. All users should migrate to AndroidX Media3. Please refer to our migration guide and script to move your codebase to the Media3 package names.

If it was not using AndroidX's version, maybe we should switch

If it was using AndroidX's version, maybe I should open another issue referencing the aforementioned issues as well? It doesnt seem like anyone has raised this ASS styling issues at the new repo, so I assume that this was either fixed or nobody noticed it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants