Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around CORS issues with jsdom in auth/hub emulators. #3224

Merged
merged 2 commits into from
Mar 19, 2021

Conversation

yuchenshi
Copy link
Member

Description

Fixes #3200.

Scenarios Tested

See tests added.

Sample Commands

N/A

@google-cla google-cla bot added the cla: yes Manual indication that this has passed CLA. label Mar 19, 2021
@@ -92,6 +92,7 @@
"cli-table": "^0.3.1",
"commander": "^4.0.1",
"configstore": "^5.0.1",
"cors": "^2.8.5",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is tricker than I thought, and I'm glad someone else solved it already. This adds 6KiB download size only, mainly due to vary (but we'd need to handle that anyway). This is also already a dependency in Firebase Functions SDK.

@yuchenshi yuchenshi merged commit cae8fa5 into master Mar 19, 2021
@yuchenshi yuchenshi deleted the ys/cors-jsdom branch March 19, 2021 21:18
devpeerapong pushed a commit to devpeerapong/firebase-tools that referenced this pull request Dec 14, 2021
)

* Work around CORS issues with jsdom in auth/hub emulators.

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Manual indication that this has passed CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auth emulator fails to create user with X-Client-Version forbidden from jsdom
3 participants