Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should getUserInfo() be under IdentityProvider? #476

Open
npm1 opened this issue Jun 8, 2023 · 1 comment
Open

Should getUserInfo() be under IdentityProvider? #476

npm1 opened this issue Jun 8, 2023 · 1 comment

Comments

@npm1
Copy link
Collaborator

npm1 commented Jun 8, 2023

Per #470 review, it is awkward to have getUserInfo() hang off of IdentityProvider. However, we currently do not really have any better ideas. While we are for now keeping it there, filing this issue to keep this open for the next few months, while it is still easy to move it around, in case we find a better home for it.

@samuelgoto
Copy link
Collaborator

samuelgoto commented Jun 8, 2023

The other option we considered was hanging it on IdentityCredential as a static method, but (a) there are more methods that we'd need to find a better home to and (b) it may not fit well with this design too.

There are a few moving parts here (example), but I agree that IdentityProvider.getUserInfo() is awkward.

We are committed to moving this to a better place if we can find one while FedCM is still in its early days of adoption (say, in the next 6-12 months it should be easy to move it to another object if we find one).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants