Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

Allow user defined attributes to override spec-defined ones. #928

Closed
GoogleCodeExporter opened this issue Apr 6, 2015 · 2 comments
Closed

Comments

@GoogleCodeExporter
Copy link

It's currently possible to use UrlValuedAttribute to tell pagespeed to process 
additional tag attributes, but not to override existing ones.  Can we remove 
this limitation?

It looks like it's just a matter of switching the order of the "Handle 
spec-defined attributes" and "Handle user-defined attributes" code in 
resource_tag_scanner.cc

Original issue reported on code.google.com by jefftk@google.com on 14 Apr 2014 at 12:57

@GoogleCodeExporter
Copy link
Author

Fixed in r3937.

Original comment by jefftk@google.com on 14 Apr 2014 at 7:58

  • Changed state: Fixed

@GoogleCodeExporter
Copy link
Author

Original comment by jmaes...@google.com on 18 Apr 2014 at 7:29

  • Added labels: Milestone-v31

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant