Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ [Amp story] Activate desktop one panel experiment to 1. #35453

Merged
merged 4 commits into from
Aug 10, 2021
Merged

✨ [Amp story] Activate desktop one panel experiment to 1. #35453

merged 4 commits into from
Aug 10, 2021

Conversation

processprocess
Copy link
Contributor

Activates amp-story-desktop-one-panel to 1.

@amp-owners-bot amp-owners-bot bot requested a review from jridgewell July 29, 2021 12:38
gmajoulet
gmajoulet reviewed Jul 29, 2021
View reviewed changes
Copy link
Contributor

@gmajoulet gmajoulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update client-side-experiments-config.json too? That's the one to use if you want the experiment to be instantly flipped

@gmajoulet
Copy link
Contributor

cc @danielrozenberg FYI :))

@danielrozenberg
Copy link
Member

Do you want to immediately set it to 1 in prod/canary config, or gradually ramp it up through the client side experiments?

@processprocess
Copy link
Contributor Author

Do you want to immediately set it to 1 in prod/canary config, or gradually ramp it up through the client side experiments?

We don't have metrics to observe before deciding to launch, so we're thinking to push it all the way to 1.

gmajoulet
gmajoulet approved these changes Jul 29, 2021
View reviewed changes
Copy link
Contributor

@gmajoulet gmajoulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code LGTM, but let's get formal wg-stories PM/UX approval before merging

danielrozenberg
danielrozenberg approved these changes Jul 29, 2021
View reviewed changes
Copy link
Member

@danielrozenberg danielrozenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval for client-side-experiments-config.json

gmajoulet
gmajoulet approved these changes Aug 10, 2021
View reviewed changes
Copy link
Contributor

@gmajoulet gmajoulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Send it!! 🚢

@processprocess processprocess merged commit 7dc536f into ampproject:main Aug 10, 2021
@processprocess processprocess deleted the activate-one-panel branch August 10, 2021 18:21
@processprocess processprocess restored the activate-one-panel branch August 10, 2021 18:21
@ampprojectbot
Copy link
Member

This PR has been picked up by the CDN and will begin deploying shortly

@ampprojectbot
Copy link
Member

This experiment is now live and being served by the CDN

@mszylkowski mszylkowski mentioned this pull request Aug 16, 2021
Closed
@processprocess processprocess deleted the activate-one-panel branch September 29, 2021 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jridgewell jridgewell jridgewell approved these changes

@gmajoulet gmajoulet gmajoulet approved these changes

@danielrozenberg danielrozenberg danielrozenberg approved these changes

Assignees
No one assigned
Labels
PR use: In Beta / Experimental PR use: In LTS PR use: In Stable WG: stories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@processprocess @gmajoulet @danielrozenberg @ampprojectbot @jridgewell