Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the check on process() be removed from AudioWorkletGlobalScope.registerProcessor()? #2045

Closed
karlt opened this issue Aug 23, 2019 · 1 comment · Fixed by #2104
Closed

Comments

@karlt
Copy link
Contributor

karlt commented Aug 23, 2019

From about #1767 (comment), there was discussion about moving the check for process() out of registerProcessor().

#1767 (comment) then resolved to add an IsCallable() check before calling process() in the rendering loop, and to "remove the redundant process() check in the instantiation of AWP".

There was no "process() check" in AudioWorkletProcessor instantiation, and the process() check in registerProcessor() is redundant now, so I wonder whether the intention was to remove the redundant check from registerProcessor()?

This would allow the client AudioWorkletProcessorConstructor to create the process() method in a way other than having it on the prototype, and would provide opportunity for reporting an error through AudioWorkletNode.onprocessorerror.

@hoch hoch self-assigned this Aug 29, 2019
@hoch
Copy link
Member

hoch commented Aug 29, 2019

Sounds reasonable. I'll work on the text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants