You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
From about #1767 (comment), there was discussion about moving the check for process() out of registerProcessor().
#1767 (comment) then resolved to add an IsCallable() check before calling process() in the rendering loop, and to "remove the redundant process() check in the instantiation of AWP".
There was no "process() check" in AudioWorkletProcessor instantiation, and the process() check in registerProcessor() is redundant now, so I wonder whether the intention was to remove the redundant check from registerProcessor()?
This would allow the client AudioWorkletProcessorConstructor to create the process() method in a way other than having it on the prototype, and would provide opportunity for reporting an error through AudioWorkletNode.onprocessorerror.
The text was updated successfully, but these errors were encountered:
From about #1767 (comment), there was discussion about moving the check for
process()
out ofregisterProcessor()
.#1767 (comment) then resolved to add an
IsCallable()
check before callingprocess()
in the rendering loop, and to "remove the redundantprocess()
check in the instantiation of AWP".There was no "
process()
check" in AudioWorkletProcessor instantiation, and theprocess()
check inregisterProcessor()
is redundant now, so I wonder whether the intention was to remove the redundant check from registerProcessor()?This would allow the client
AudioWorkletProcessorConstructor
to create theprocess()
method in a way other than having it on the prototype, and would provide opportunity for reporting an error throughAudioWorkletNode.onprocessorerror
.The text was updated successfully, but these errors were encountered: