Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When can we drop IE11 support? #1578

Closed
LeaVerou opened this issue Oct 2, 2018 · 16 comments
Closed

When can we drop IE11 support? #1578

LeaVerou opened this issue Oct 2, 2018 · 16 comments
Milestone

Comments

@LeaVerou
Copy link
Member

LeaVerou commented Oct 2, 2018

Once we can drop IE11, we will be able to depend on CSS variables.
This means we can finally get rid of the whole problem "how do all themes work with all languages?". Themes would just define variables, language definitions would just use these variables.

What do you think?

@mAAdhaTTah
Copy link
Member

I'm personally OK w/ dropping IE11 support, but I know projects I work on generally still support it as MSFT is still supporting that browser. Additionally, IE11 still works w/ Windows 10, so MSFT may continue to support it for a while.

This is also definitely a breaking change, so we should release as a 2.0. If we drop IE11 support, we could probably go all-in on ES6 as well, if that helps the code at all.

Just some thoughts. Not really sure where I stand, tbh.

@ExE-Boss
Copy link
Contributor

ExE-Boss commented Dec 6, 2018

We could maybe support CSS variables and use postcss-custom-properties for rudimentary IE11 support.

@LeaVerou
Copy link
Member Author

LeaVerou commented Dec 7, 2018

That defeats the whole point of using CSS variables, since any combination of theme and language would have to be pre-compiled.

@LeaVerou
Copy link
Member Author

LeaVerou commented May 8, 2020

I'm wondering if we could start using CSS variables without completely dropping IE11 support. We could use PostCSS or something to add fallbacks, and IE11 would just use those fallbacks. So people on IE11 would still get highlighting, just not customized highlighting. Would that make sense?

@RunDevelopment
Copy link
Member

@joshgoebel
Copy link

Are you planning to support it until then?

@RunDevelopment
Copy link
Member

Given the current progress on v2, I can't blame you for thinking that but no :)

@mAAdhaTTah
Copy link
Member

Technically, dropping IE11 support is a breaking change, so we really should support it until then, unfortunately.

@mAAdhaTTah
Copy link
Member

Unless I misunderstood the comment/question. To rephrase, v1 should support IE11. v2 was never intended to. So really, we'll support IE11 until whenever v2 gets out. Or at least, that's what I think we should do.

@RunDevelopment
Copy link
Member

To rephrase, v1 should support IE11. v2 was never intended to.

Yup, that's pretty much it. We'll support IE11 for the whole of v1.x and then drop it in v2.0.0.

@ljharb
Copy link

ljharb commented May 19, 2021

"users stop using it" is a date that is not tightly correlated to "a company stops supporting it".

@LeaVerou
Copy link
Member Author

Yup, agreed too. Whoever needs IE11 support can just stay on v1.

@RunDevelopment
Copy link
Member

IE11 is dropped in v2.

@xjArea
Copy link

xjArea commented Sep 19, 2022

I don't think it's a problem to delete IE11 in V2, but I recently updated Prism.js and found that V1 can't be used in IE11. Check the error and find that it's a RegExp problem. In V1.25.0, IE11 still OK, but V1.26.0 will report an error, so is it not supported now ? 😭

@LeaVerou
Copy link
Member Author

I don't think it's a problem to delete IE11 in V2, but I recently updated Prism.js and found that V1 can't be used in IE11. Check the error and find that it's a RegExp problem. In V1.25.0, IE11 still OK, but V1.26.0 will report an error, so is it not supported now ? 😭

Can you please file this as a new bug? This is not intentional.

@xjArea
Copy link

xjArea commented Sep 19, 2022

file this as a new bug : #3558

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants