Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Problem/Bug]: Page loaded after calling window.stop() #4808

Open
szanto90balazs opened this issue Sep 12, 2024 · 2 comments
Open

[Problem/Bug]: Page loaded after calling window.stop() #4808

szanto90balazs opened this issue Sep 12, 2024 · 2 comments
Assignees
@JosephJin0815 @vbryh-msft @lflores-ms
Labels
bug Something isn't working regression Something used to work but doesn't anymore tracked We are tracking this work internally.

Comments

@szanto90balazs
Copy link

szanto90balazs commented Sep 12, 2024 •
edited by champnic
Loading

What happened?

We have a test page for verifying address bar spoofing is not possible in our application and we started observing a new window loading behavior starting with WebView2 runtime v130 (tested on 130.0.2832.0)

When we open a new window, set its location to a valid URL and immediately call window.stop(), the page still gets loaded.

 function run() {
            let win = open("about:blank");
            win.document.write("<title>DuckDuckGo - Privacy, Simplified.</title>Not DDG.");
            setTimeout(() => {
                win.location = "https://duckduckgo.com/";
                win.window.stop();
            }, 500);

Seems like this only happens when even listener(s) attached to CoreWebView2.NewWindowRequested, but it's necessary for us to be able to customize the new window as well.

The issue can be reproduced with the WebView2WpfBrowser sample app if it's using WebView2 runtime v130+ (I used 130.0.2832.0). See recording

WebView2WpfBrowser_v130_reproducible.mp4

The issue cannot be reproduced with the sample app for WebView2 runtime v128 and v129

The complete code, copied from https://privacy-test-pages.site/security/address-bar-spoofing/spoof-about-blank-rewrite.html:

<!DOCTYPE html>
<html>

<head>
    <meta charset="utf-8">
    <meta name="viewport" content="width=device-width">
    <title>About:Blank Rewrite Spoof</title>
    <script>
        // eslint-disable-next-line no-unused-vars
        function run() {
            let win = open("about:blank");
            win.document.write("<title>DuckDuckGo - Privacy, Simplified.</title>Not DDG.");
            setTimeout(() => {
                win.location = "https://duckduckgo.com/";
                win.window.stop();
            }, 500);
        }
    </script>
</head>

<body>
    <p><a href="./index.html">[Back]</a></p>
    This test will try to confuse the browser to show the wrong domain in the URL bar by opening an about:blank page,
    rewriting the content, starting a navigation elsewhere and quickly stopping the
    navigation using window.stop().
    <button id="run" onclick="run()">Start</button>
</body>

</html>

Importance

Important. My app's user experience is significantly compromised.

Runtime Channel

Prerelease (Edge Canary/Dev/Beta)

Runtime Version

130.0.2832.0

SDK Version

No response

Framework

WPF

Operating System

Windows 10, Windows 11

OS Version

No response

Repro steps

  1. Checkout https://github.com/MicrosoftEdge/WebView2Samples/tree/main/SampleApps/WebView2WpfBrowser
  2. Set up such that it uses the canary runtime (130.0.2832.0)
  3. Compile and start the sample application
  4. Go to https://privacy-test-pages.site/security/address-bar-spoofing/spoof-about-blank-rewrite.html
  5. Click on the button with label "Start"
  6. New window should be opened

Expectation: no page should be loaded, just about:blank

Repros in Edge Browser

No, issue does not reproduce in the corresponding Edge version

Regression

Regression in newer Runtime

Last working version (if regression)

Runtime 129.0.2792.31

AB#53858698
@szanto90balazs szanto90balazs added the bug Something isn't working label Sep 12, 2024
@github-actions github-actions bot added the regression Something used to work but doesn't anymore label Sep 12, 2024
@vbryh-msft vbryh-msft added the tracked We are tracking this work internally. label Sep 12, 2024
@JosephJin0815
Copy link
Contributor

Hi @szanto90balazs, thanks for reporting this bug. We will investigate and report back.

@JosephJin0815 JosephJin0815 self-assigned this Sep 18, 2024
@JosephJin0815
Copy link
Contributor

A fixed has been made, it will be Edge Runtime version >= 130.0.2842.0 to be released in about a week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JosephJin0815 JosephJin0815

@vbryh-msft vbryh-msft

@lflores-ms lflores-ms

Labels
bug Something isn't working regression Something used to work but doesn't anymore tracked We are tracking this work internally.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@szanto90balazs @JosephJin0815 @vbryh-msft @lflores-ms